Issue 2794833003: Use SubStringScanner to scan generic comments.

Issue 2794833003: Use SubStringScanner to scan generic comments. (Closed)

Created:
3 years, 8 months ago by scheglov

Modified:
3 years, 8 months ago

Reviewers:
ahe, Paul Berry

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Use SubStringScanner to scan generic comments. R=ahe@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/21982e562cd4a8bb862ee046d2c22c8fcbc5b38f

Patch Set 2 : Revert formatting changes. #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -2 lines)			Patch
	M	pkg/front_end/lib/src/fasta/parser/parser.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	pkg/front_end/lib/src/fasta/scanner/string_scanner.dart	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ahe

https://codereview.chromium.org/2794833003/diff/1/pkg/front_end/lib/src/fasta/scanner/string_scanner.dart File pkg/front_end/lib/src/fasta/scanner/string_scanner.dart (left): https://codereview.chromium.org/2794833003/diff/1/pkg/front_end/lib/src/fasta/scanner/string_scanner.dart#oldcode28 pkg/front_end/lib/src/fasta/scanner/string_scanner.dart:28: static String ensureZeroTermination(String string) { Please revert unrelated formatting ...

3 years, 8 months ago (2017-04-04 08:17:00 UTC) #2

scheglov

3 years, 8 months ago (2017-04-04 15:45:49 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
21982e562cd4a8bb862ee046d2c22c8fcbc5b38f (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages