Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: pkg/front_end/lib/src/fasta/parser/parser.dart

Issue 2794833003: Use SubStringScanner to scan generic comments. (Closed)
Patch Set: Revert formatting changes. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/scanner/string_scanner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/parser/parser.dart
diff --git a/pkg/front_end/lib/src/fasta/parser/parser.dart b/pkg/front_end/lib/src/fasta/parser/parser.dart
index ecf6fc15339d4f334ec5a4e9a6b0bb794b508bf3..772f259aca64c557621b5bca9d814b0ffdd5596c 100644
--- a/pkg/front_end/lib/src/fasta/parser/parser.dart
+++ b/pkg/front_end/lib/src/fasta/parser/parser.dart
@@ -3834,8 +3834,7 @@ class Parser {
/// Scans the given [code], and returns the tokens, otherwise returns `null`.
Token _scanGenericMethodComment(String code, int offset) {
- // TODO(scheglov) Let StringScanner to specify the string offset.
- var scanner = new StringScanner(' ' * offset + code);
+ var scanner = new SubStringScanner(offset, code);
Token firstToken = scanner.tokenize();
if (scanner.hasErrors) {
return null;
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/scanner/string_scanner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698