Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2794713002: Use separate pixel reference images for windows 10 and 7 (Closed)

Created:
3 years, 8 months ago by jbauman
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use separate pixel reference images for windows 10 and 7 We use different video processors on these platforms, so the results are allowed to be slightly different. BUG=704389 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2794713002 Cr-Commit-Position: refs/heads/master@{#461524} Committed: https://chromium.googlesource.com/chromium/src/+/062ee74fcfe10a4141eedfdaf37cbf7e9fe1b21f

Patch Set 1 #

Total comments: 1

Patch Set 2 : replace os-type string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M content/test/gpu/gpu_tests/cloud_storage_integration_test_base.py View 1 1 chunk +5 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
jbauman
3 years, 8 months ago (2017-04-01 01:06:39 UTC) #7
Ken Russell (switch to Gerrit)
lgtm with naming nit https://codereview.chromium.org/2794713002/diff/1/content/test/gpu/gpu_tests/cloud_storage_integration_test_base.py File content/test/gpu/gpu_tests/cloud_storage_integration_test_base.py (right): https://codereview.chromium.org/2794713002/diff/1/content/test/gpu/gpu_tests/cloud_storage_integration_test_base.py#newcode255 content/test/gpu/gpu_tests/cloud_storage_integration_test_base.py:255: base_name = "win10_" + base_name ...
3 years, 8 months ago (2017-04-01 01:18:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2794713002/20001
3 years, 8 months ago (2017-04-03 19:08:41 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 20:44:16 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/062ee74fcfe10a4141eedfdaf37c...

Powered by Google App Engine
This is Rietveld 408576698