Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2794693002: [wasm] Gate SIMD load/store opcodes with the --wasm-simd-prototype flag. (Closed)

Created:
3 years, 8 months ago by gdeepti
Modified:
3 years, 8 months ago
Reviewers:
bbudge, Mircea Trofin
CC:
v8-reviews_googlegroups.com, wasm-v8_google.com, bradnelson
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Gate SIMD load/store opcodes with the --wasm-simd-prototype flag. BUG=chromium:702460 R=mtrofin@chromium.org, bbudge@chromium.org Review-Url: https://codereview.chromium.org/2794693002 Cr-Commit-Position: refs/heads/master@{#44319} Committed: https://chromium.googlesource.com/v8/v8/+/0f9680cd2d4bdf8c6f4bd3681053e6192e3dbb74

Patch Set 1 #

Patch Set 2 : Fix copyright header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
M src/wasm/function-body-decoder.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A test/mjsunit/regress/wasm/regression-702460.js View 1 1 chunk +47 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/wasm-constants.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
gdeepti
3 years, 8 months ago (2017-03-31 21:56:36 UTC) #6
bbudge
lgtm
3 years, 8 months ago (2017-03-31 22:10:10 UTC) #7
Mircea Trofin
lgtm
3 years, 8 months ago (2017-03-31 22:51:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2794693002/20001
3 years, 8 months ago (2017-03-31 22:51:27 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 22:53:06 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/0f9680cd2d4bdf8c6f4bd3681053e6192e3...

Powered by Google App Engine
This is Rietveld 408576698