HTML Imports: Fix yet another FOUC

Remove setNeedsRecalcStyle() in Document::didLoadAllImports().

r173248 added it but there is a performance concern.
This change repalces it with a modest alternative that does same as what didRemoveAllPendingStylesheet() has been doing.

This change also removed 500ms sleep from a test that was added at r173248.

TEST=none
R=ojan@chromium.org,esprehn@chromium.org
BUG=367386
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173680

[Hajime Morrita, 2014-05-08 01:23:15]

Elliott: PTAL?

I'm reverting the oiriginal fix https://codereview.chromium.org/270623007/

This change consults StyleEngine to see how styles are recalculated. For
non-style imports, styles won't be recalculated at all thanks for style analysis
of StyleEngine.

[esprehn, 2014-05-08 01:38:43]

lgtm, this looks much better!

[ojan, 2014-05-08 03:57:06]

https://codereview.chromium.org/279463002/diff/1/LayoutTests/fast/html/import...
File LayoutTests/fast/html/imports/import-link-with-media-query.html (right):

https://codereview.chromium.org/279463002/diff/1/LayoutTests/fast/html/import...
LayoutTests/fast/html/imports/import-link-with-media-query.html:6:
setTimeout(function() { testRunner.notifyDone(); }, 500);
Does this really need a setTimeout? We can't just wait for the load event? 500ms
is a long time for a layout test.

[esprehn, 2014-05-08 05:17:34]

https://codereview.chromium.org/279463002/diff/1/LayoutTests/fast/html/import...
File LayoutTests/fast/html/imports/import-link-with-media-query.html (right):

https://codereview.chromium.org/279463002/diff/1/LayoutTests/fast/html/import...
LayoutTests/fast/html/imports/import-link-with-media-query.html:6:
setTimeout(function() { testRunner.notifyDone(); }, 500);
On 2014/05/08 03:57:06, ojan wrote:
> Does this really need a setTimeout? We can't just wait for the load event?
500ms
> is a long time for a layout test.

Err yeah, this shouldn't need a set timeout. What are you actually waiting for?

[Hajime Morrita, 2014-05-08 17:54:34]

OK, so as revert change has been stuck due to a test flakiness, I'd land this as
a fix, instead of a re-land.
Could you take another look just in case, Elliott?

> Err yeah, this shouldn't need a set timeout. What are you actually waiting
for?
This actually waits window@onload. I rewrote as such.

[esprehn, 2014-05-08 19:13:29]

lgtm, few comments.

https://codereview.chromium.org/279463002/diff/40001/LayoutTests/fast/html/im...
File LayoutTests/fast/html/imports/import-element-removed-flag.html (right):

https://codereview.chromium.org/279463002/diff/40001/LayoutTests/fast/html/im...
LayoutTests/fast/html/imports/import-element-removed-flag.html:72:
setTimeout(check, 0);
What's this setTimeout waiting for?

https://codereview.chromium.org/279463002/diff/40001/LayoutTests/fast/html/im...
File LayoutTests/fast/html/imports/import-link-with-media-query.html (right):

https://codereview.chromium.org/279463002/diff/40001/LayoutTests/fast/html/im...
LayoutTests/fast/html/imports/import-link-with-media-query.html:6:
window.addEventListener("load", function() {
onload = function() {

[Hajime Morrita, 2014-05-08 19:42:39]

https://codereview.chromium.org/279463002/diff/40001/LayoutTests/fast/html/im...
File LayoutTests/fast/html/imports/import-element-removed-flag.html (right):

https://codereview.chromium.org/279463002/diff/40001/LayoutTests/fast/html/im...
LayoutTests/fast/html/imports/import-element-removed-flag.html:72:
setTimeout(check, 0);
On 2014/05/08 19:13:29, esprehn wrote:
> What's this setTimeout waiting for?
This is a busy loop. I did this because the load event wasn't implemented yet.
Probably I should rewrite this to event-based. I'll do it in a separate change.

[Hajime Morrita, 2014-05-08 19:42:49]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-05-08 19:44:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/morrita@chromium.org/279463002/40001

[commit-bot: I haz the power, 2014-05-08 21:02:48]

Change committed as 173680