LayoutTests/fast/html/imports/import-link-with-media-query.html - Issue 279463002: HTML Imports: Fix yet another FOUC

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/html/imports/import-link-with-media-query.html

Issue 279463002: HTML Imports: Fix yet another FOUC (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script>	2 <script>

3 if (window.testRunner)	3 if (window.testRunner) {

4 testRunner.dumpAsText();	4 testRunner.dumpAsText();

	5 testRunner.waitUntilDone();

	6 setTimeout(function() { testRunner.notifyDone(); }, 500);
	ojan 2014/05/08 03:57:06 Does this really need a setTimeout? We can't just Does this really need a setTimeout? We can't just wait for the load event? 500ms is a long time for a layout test. esprehn 2014/05/08 05:17:34 Err yeah, this shouldn't need a set timeout. What Show quoted text On 2014/05/08 03:57:06, ojan wrote: > Does this really need a setTimeout? We can't just wait for the load event? 500ms > is a long time for a layout test. Err yeah, this shouldn't need a set timeout. What are you actually waiting for?
	7 }

5 </script>	8 </script>

6 <link href="resources/import-link-with-media-query.html" rel=import>	9 <link href="resources/import-link-with-media-query.html" rel=import>

7 This test passes if it does not crash under ASAN.	10 This test passes if it does not crash under ASAN.

OLD	NEW