Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2794603002:
[closed] Avoid double counting time on page (Closed)
|
Created:
3 years, 8 months ago by Bryan McQuade Modified:
3 years, 8 months ago Reviewers:
Charlie Harrison CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org, speed-metrics-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionThis change has moved to https://codereview.chromium.org/2800873002
BUG=651844
Patch Set 1 #Patch Set 2 : fix comment #Patch Set 3 : add dcheck #Patch Set 4 : more comments #Patch Set 5 : fix compile #Patch Set 6 : comment fix #Patch Set 7 : re-enable fixed test #Patch Set 8 : simplify #
Messages
Total messages: 27 (26 generated)
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Alternative fix to 2789783003 BUG= ========== to ========== Avoid double counting time on page For navigations whose lifetimes are contained entirely within other navigations, we were previously crediting 'time in tab' to both navigations, causing us to double count. This change credits all time spent in such cases to the navigation with the longer lifetime. BUG=651844 ==========
Description was changed from ========== Avoid double counting time on page For navigations whose lifetimes are contained entirely within other navigations, we were previously crediting 'time in tab' to both navigations, causing us to double count. This change credits all time spent in such cases to the navigation with the longer lifetime. BUG=651844 ========== to ========== Avoid double counting time on page For navigations whose lifetimes are contained entirely within other navigations, we were previously crediting 'time in tab' to both navigations, causing us to double count. This change credits all time spent in such cases to the navigation with the longer lifetime. This also fixes an extension test caused this particular case to be encountered with triggered a DCHECK in ComputePageLoadExtraInfo. BUG=651844 ==========
bmcquade@chromium.org changed reviewers: + csharrison@chromium.org
PTAL for page_load_metrics changes, thanks!
Description was changed from ========== Avoid double counting time on page For navigations whose lifetimes are contained entirely within other navigations, we were previously crediting 'time in tab' to both navigations, causing us to double count. This change credits all time spent in such cases to the navigation with the longer lifetime. This also fixes an extension test caused this particular case to be encountered with triggered a DCHECK in ComputePageLoadExtraInfo. BUG=651844 ========== to ========== Avoid double counting time on page For navigations whose lifetimes are contained entirely within other navigations, we were previously crediting 'time in tab' to both navigations, causing us to double count. This change credits all time spent in such cases to the navigation with the longer lifetime. This also fixes an extension test that caused this particular case to be encountered, which triggered a DCHECK in ComputePageLoadExtraInfo. BUG=651844 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
Message was sent while issue was closed.
Description was changed from ========== Avoid double counting time on page For navigations whose lifetimes are contained entirely within other navigations, we were previously crediting 'time in tab' to both navigations, causing us to double count. This change credits all time spent in such cases to the navigation with the longer lifetime. This also fixes an extension test that caused this particular case to be encountered, which triggered a DCHECK in ComputePageLoadExtraInfo. BUG=651844 ========== to ========== This change has moved to https://codereview.chromium.org/2800873002 BUG=651844 ========== |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
