Revert "[NTP::Downloads] Replace 36dp ... resources with vector ... ."

Revert "[NTP::Downloads] Replace 36dp ... resources with vector ... ."

This is an exact revert of commit
267b85777ea8bb3859472dc88582e946131a552c 
(https://codereview.chromium.org/2731303002).

Reason: The apk size win is not comparable to performance loss on such
frequently used resources.

BUG=693552, 697861
Review-Url: https://codereview.chromium.org/2794513002
Cr-Commit-Position: refs/heads/master@{#461378}
Committed: https://chromium.googlesource.com/chromium/src/+/ec2749f33bd385686d8d6c522d20317ff00fecdb

[vitaliii, 2017-03-31 12:55:51]

vitaliii@chromium.org changed reviewers:
+ dfalcantara@chromium.org, dgn@chromium.org

[vitaliii, 2017-03-31 12:55:52]

dgn@chromium.org: Please review changes in 
ntp/snippets

dfalcantara@chromium.org: Please review changes in 
java/res and browser/download

twellington@: FYI.

[vitaliii, 2017-03-31 12:56:03]

The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 12:56:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 13:37:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 13:37:57]

Dry run: This issue passed the CQ dry run.

[dgn, 2017-03-31 14:48:15]

Is that an exact revert of the other commit? If not, can you generate a revert
through the UI and then show the changes as second patchset?

Also, what is that dependent patch?

[vitaliii, 2017-03-31 15:05:41]

Description was changed from

==========
Revert "[NTP::Downloads] Replace 36dp ... resources with vector ... ."

This reverts commit 267b85777ea8bb3859472dc88582e946131a552c
(https://codereview.chromium.org/2731303002).

Reason: The apk size win is not comparable to performance loss on such
frequently used resources.

BUG=693552,697861
==========

to

==========
Revert "[NTP::Downloads] Replace 36dp ... resources with vector ... ."

This is an exact revert of commit
267b85777ea8bb3859472dc88582e946131a552c 
(https://codereview.chromium.org/2731303002).

Reason: The apk size win is not comparable to performance loss on such
frequently used resources.

BUG=693552,697861
==========

[vitaliii, 2017-03-31 15:06:32]

The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 15:06:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vitaliii, 2017-03-31 15:12:30]

On 2017/03/31 14:48:15, dgn wrote:
> Is that an exact revert of the other commit? If not, can you generate a revert
> through the UI and then show the changes as second patchset?
> 
> Also, what is that dependent patch?

dgn@,

This is an exact revert. I added this to the description.

Dependent patch was for testing (otherwise the Clank would crash). I removed it
and tested this CL in a different way.

[commit-bot: I haz the power, 2017-03-31 15:47:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 15:47:04]

Dry run: This issue passed the CQ dry run.

[dgn, 2017-03-31 17:22:16]

On 2017/03/31 15:12:30, vitaliii wrote:
> On 2017/03/31 14:48:15, dgn wrote:
> > Is that an exact revert of the other commit? If not, can you generate a
revert
> > through the UI and then show the changes as second patchset?
> > 
> > Also, what is that dependent patch?
> 
> dgn@,
> 
> This is an exact revert. I added this to the description.
> 
> Dependent patch was for testing (otherwise the Clank would crash). I removed
it
> and tested this CL in a different way.

Thanks, lgtm. 

It's sad that you have to remove it. Would it be possible at some point to have
a TL;DR/write up of how to set up vectors for tinting and scaling, and how you
evaluated the performance? It will very likely come up again, and not having to
cross reference a couple of CLs, issues and docs at that moment would be
convenient.

[gone, 2017-03-31 17:27:02]

lgtm

[vitaliii, 2017-04-03 06:17:33]

The CQ bit was checked by vitaliii@chromium.org

[commit-bot: I haz the power, 2017-04-03 06:17:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 06:56:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491200253117840,
"parent_rev": "f1f078d5f56503e5cf8b5490875e1e1ec9c252ba", "commit_rev":
"ec2749f33bd385686d8d6c522d20317ff00fecdb"}

[commit-bot: I haz the power, 2017-04-03 06:57:23]

Description was changed from

==========
Revert "[NTP::Downloads] Replace 36dp ... resources with vector ... ."

This is an exact revert of commit
267b85777ea8bb3859472dc88582e946131a552c 
(https://codereview.chromium.org/2731303002).

Reason: The apk size win is not comparable to performance loss on such
frequently used resources.

BUG=693552,697861
==========

to

==========
Revert "[NTP::Downloads] Replace 36dp ... resources with vector ... ."

This is an exact revert of commit
267b85777ea8bb3859472dc88582e946131a552c 
(https://codereview.chromium.org/2731303002).

Reason: The apk size win is not comparable to performance loss on such
frequently used resources.

BUG=693552,697861

Review-Url: https://codereview.chromium.org/2794513002
Cr-Commit-Position: refs/heads/master@{#461378}
Committed:
https://chromium.googlesource.com/chromium/src/+/ec2749f33bd385686d8d6c522d20...
==========

[commit-bot: I haz the power, 2017-04-03 06:57:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ec2749f33bd385686d8d6c522d20...