Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sandbox/linux/BUILD.gn

Issue 2794483002: sandbox/linux: Enable -Wshift-negative-value after LSS roll. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/linux/BUILD.gn
diff --git a/sandbox/linux/BUILD.gn b/sandbox/linux/BUILD.gn
index 0644c27e35cd6e695c0e1187770085d5aac424f2..d250d216acc11f0d4c49c89779055cd33990c2c7 100644
--- a/sandbox/linux/BUILD.gn
+++ b/sandbox/linux/BUILD.gn
@@ -146,11 +146,6 @@ source_set("sandbox_linux_unittests_sources") {
"seccomp-bpf/trap_unittest.cc",
]
deps += [ ":bpf_dsl_golden" ]
-
- # syscall_parameters_restrictions_unittests.cc uses MAKE_PROCESS_CPUCLOCK,
- # which shifts signed ints around, which has undefined behavior.
- # TODO(thakis): Fix that in LSS, then remove this flag here.
- cflags = [ "-Wno-shift-negative-value" ]
}
if (compile_credentials) {
sources += [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698