Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2794483002: sandbox/linux: Enable -Wshift-negative-value after LSS roll. (Closed)

Created:
3 years, 8 months ago by Nico
Modified:
3 years, 8 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, jln+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

sandbox/linux: Enable -Wshift-negative-value after LSS roll. BUG=507717 Review-Url: https://codereview.chromium.org/2794483002 Cr-Commit-Position: refs/heads/master@{#461127} Committed: https://chromium.googlesource.com/chromium/src/+/3ee77710665d0ad9d9a9d05afa5ee21062939378

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M sandbox/linux/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Nico
Sorry for the churn.
3 years, 8 months ago (2017-03-31 11:08:08 UTC) #3
Robert Sesek
LGTM. Thanks for the speedy cleanup!
3 years, 8 months ago (2017-03-31 15:04:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2794483002/1
3 years, 8 months ago (2017-03-31 15:18:22 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 15:23:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3ee77710665d0ad9d9a9d05afa5e...

Powered by Google App Engine
This is Rietveld 408576698