Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h

Issue 2794453002: [Bindings] Replace V8HiddenValue in generated code with V8PrivateProperty (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h b/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h
index e6a1fdff4e79929855e6928f685656811909c5c3..6311c8d7bf7e051393c899796e6901b5d76f3c7c 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h
@@ -39,6 +39,7 @@ class ScriptWrappable;
X(MutationObserver, Callback) \
X(NamedConstructor, Initialized) \
X(PerformanceObserver, Callback) \
+ X(PopStateEvent, State) \
X(SameObject, NotificationActions) \
X(SameObject, NotificationData) \
X(SameObject, NotificationVibrate) \
@@ -105,6 +106,10 @@ class CORE_EXPORT V8PrivateProperty {
return object->SetPrivate(context(), m_privateSymbol, value).ToChecked();
}
+ bool deleteProperty(v8::Local<v8::Object> object) const {
+ return object->DeletePrivate(context(), m_privateSymbol).ToChecked();
+ }
+
v8::Local<v8::Private> getPrivate() const { return m_privateSymbol; }
private:
@@ -168,7 +173,7 @@ class CORE_EXPORT V8PrivateProperty {
privateProp->m_symbolWindowDocumentCachedAccessor.newLocal(isolate));
}
- static Symbol createSymbol(v8::Isolate* isolate, const char* symbol) {
+ static Symbol getSymbol(v8::Isolate* isolate, const char* symbol) {
return Symbol(isolate, createCachedV8Private(isolate, symbol));
}
@@ -177,6 +182,7 @@ class CORE_EXPORT V8PrivateProperty {
static v8::Local<v8::Private> createV8Private(v8::Isolate*,
const char* symbol);
+ // TODO(peria): Remove this method. We should not use v8::Private::ForApi().
static v8::Local<v8::Private> createCachedV8Private(v8::Isolate*,
const char* symbol);

Powered by Google App Engine
This is Rietveld 408576698