[Bindings] Replace V8HiddenValue in generated code with V8PrivateProperty

third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8PrivateProperty_h
 #define V8PrivateProperty_h
 
 #include <memory>
 
 #include "bindings/core/v8/ScriptPromiseProperties.h"
@@ skipping 21 matching lines @@
   X(CustomElement, TagName)                           \
   X(CustomElement, Type)                              \
   X(DOMException, Error)                              \
   X(ErrorEvent, Error)                                \
   X(IDBObserver, Callback)                            \
   X(IntersectionObserver, Callback)                   \
   X(MessageEvent, CachedData)                         \
   X(MutationObserver, Callback)                       \
   X(NamedConstructor, Initialized)                    \
   X(PerformanceObserver, Callback)                    \
+  X(PopStateEvent, State)                             \
   X(SameObject, NotificationActions)                  \
   X(SameObject, NotificationData)                     \
   X(SameObject, NotificationVibrate)                  \
   X(SameObject, PerformanceLongTaskTimingAttribution) \
   X(V8NodeFilterCondition, Filter)
 
 // The getter's name for a private property.
 #define V8_PRIVATE_PROPERTY_GETTER_NAME(InterfaceName, PrivateKeyName) \
   get##InterfaceName##PrivateKeyName
 
@@ skipping 46 matching lines @@
     v8::Local<v8::Value> getOrEmpty(v8::Local<v8::Object> object) const {
       if (hasValue(object))
         return getOrUndefined(object);
       return v8::Local<v8::Value>();
     }
 
     bool set(v8::Local<v8::Object> object, v8::Local<v8::Value> value) const {
       return object->SetPrivate(context(), m_privateSymbol, value).ToChecked();
     }
 
+    bool deleteProperty(v8::Local<v8::Object> object) const {
+      return object->DeletePrivate(context(), m_privateSymbol).ToChecked();
+    }
+
     v8::Local<v8::Private> getPrivate() const { return m_privateSymbol; }
 
    private:
     friend class V8PrivateProperty;
     // The following classes are exceptionally allowed to call to
     // getFromMainWorld.
     friend class V8CustomEvent;
     friend class V8ServiceWorkerMessageEventInternal;
 
     Symbol(v8::Isolate* isolate, v8::Local<v8::Private> privateSymbol)
@@ skipping 43 matching lines @@
       privateProp->m_symbolWindowDocumentCachedAccessor.set(
           isolate, createCachedV8Private(
                        isolate, V8_PRIVATE_PROPERTY_SYMBOL_STRING(
                                     "Window", "DocumentCachedAccessor")));
     }
     return Symbol(
         isolate,
         privateProp->m_symbolWindowDocumentCachedAccessor.newLocal(isolate));
   }
 
-  static Symbol createSymbol(v8::Isolate* isolate, const char* symbol) {
+  static Symbol getSymbol(v8::Isolate* isolate, const char* symbol) {
     return Symbol(isolate, createCachedV8Private(isolate, symbol));
   }
 
  private:
   V8PrivateProperty() {}
 
   static v8::Local<v8::Private> createV8Private(v8::Isolate*,
                                                 const char* symbol);
+  // TODO(peria): Remove this method. We should not use v8::Private::ForApi().
   static v8::Local<v8::Private> createCachedV8Private(v8::Isolate*,
                                                       const char* symbol);
 
 #define V8_PRIVATE_PROPERTY_DECLARE_MEMBER(InterfaceName, KeyName) \
   v8::Eternal<v8::Private> V8_PRIVATE_PROPERTY_MEMBER_NAME(        \
       InterfaceName, KeyName);  // NOLINT(readability/naming/underscores)
   V8_PRIVATE_PROPERTY_FOR_EACH(V8_PRIVATE_PROPERTY_DECLARE_MEMBER)
 #undef V8_PRIVATE_PROPERTY_DECLARE_MEMBER
 
   // TODO(peria): Do not use this specialized hack for
   // Window#DocumentCachedAccessor. This is required to put v8::Private key in
   // a snapshot, and it cannot be a v8::Eternal<> due to V8 serializer's
   // requirement.
   ScopedPersistent<v8::Private> m_symbolWindowDocumentCachedAccessor;
 };
 
 }  // namespace blink
 
 #endif  // V8PrivateProperty_h