Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2794443002: [debug] fix coverage for non-default test variants. (Closed)

Created:
3 years, 8 months ago by Yang
Modified:
3 years, 8 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com, Yang, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[debug] fix coverage for non-default test variants. R=jgruber@chromium.org BUG=v8:6165 Review-Url: https://codereview.chromium.org/2794443002 Cr-Commit-Position: refs/heads/master@{#44329} Committed: https://chromium.googlesource.com/v8/v8/+/5833e7774403197b91d39ca7e6bb1584b37ab84b

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 1

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M src/debug/debug-coverage.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M test/inspector/cpu-profiler/coverage.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/inspector/inspector.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
Yang
3 years, 8 months ago (2017-03-31 08:27:45 UTC) #1
jgruber
What problems does this change fix?
3 years, 8 months ago (2017-03-31 08:44:32 UTC) #4
Yang
https://codereview.chromium.org/2794443002/diff/20001/src/debug/debug-coverage.cc File src/debug/debug-coverage.cc (left): https://codereview.chromium.org/2794443002/diff/20001/src/debug/debug-coverage.cc#oldcode155 src/debug/debug-coverage.cc:155: count = info->has_reported_binary_coverage() ? 0 : 1; If this ...
3 years, 8 months ago (2017-03-31 08:59:49 UTC) #7
jgruber
lgtm
3 years, 8 months ago (2017-03-31 09:04:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2794443002/40001
3 years, 8 months ago (2017-04-03 08:29:22 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 08:58:25 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/5833e7774403197b91d39ca7e6bb1584b37...

Powered by Google App Engine
This is Rietveld 408576698