Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2794403002: Rebaseline some color profile tests (Closed)

Created:
3 years, 8 months ago by Stephen Chennney
Modified:
3 years, 8 months ago
Reviewers:
Noel Gordon
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rebaseline some color profile tests virtual/gpu-rasterization/images/webp-color-profile-lossy.html is passing, it seems, and needs new baselines. virtual/gpu-rasterization/images/color-profile-filter.html seems to be passing everywhere already. virtual/gpu-rasterization/images/color-profile-background-clip-text.html is no longer crashing and produces consistent result, but those results are wrong due to crbug.com/670292. So rebaseline until we fix the bug. TBR=noel@chromium.org BUG=624709, 587737, 624233 Review-Url: https://codereview.chromium.org/2794403002 Cr-Commit-Position: refs/heads/master@{#462642} Committed: https://chromium.googlesource.com/chromium/src/+/573263ce1c07afc7d3bcd1a92ffc18e8c6fd7f54

Patch Set 1 #

Patch Set 2 : New baselines #

Patch Set 3 : Rebaseline #

Patch Set 4 : Mark virtual/gpu-rasterization/images/color-profile-background-clip-text.html as flaky #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/images/color-profile-filter-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-clip-text-expected.png View 1 2 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/webp-color-profile-lossy-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-background-clip-text-expected.png View 1 2 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-filter-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu-rasterization/images/color-profile-background-clip-text-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/gpu-rasterization/images/color-profile-background-clip-text-expected.png View 1 2 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu-rasterization/images/color-profile-background-clip-text-expected.png View 1 2 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu-rasterization/images/color-profile-filter-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-background-clip-text-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-filter-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-background-clip-text-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/webp-color-profile-lossy-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/images/color-profile-background-clip-text-expected.png View 1 2 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/images/webp-color-profile-lossy-expected.png View 1 Binary file 0 comments Download

Messages

Total messages: 14 (10 generated)
Stephen Chennney
It may be the some of these are flaky, but we can't tell right now.
3 years, 8 months ago (2017-04-04 17:04:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2794403002/60001
3 years, 8 months ago (2017-04-06 20:37:40 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/573263ce1c07afc7d3bcd1a92ffc18e8c6fd7f54
3 years, 8 months ago (2017-04-06 22:10:58 UTC) #12
Noel Gordon
3 years, 8 months ago (2017-04-06 23:17:14 UTC) #14
On 2017/04/04 17:04:46, Stephen Chennney wrote:
> It may be the some of these are flaky, but we can't tell right now.

LGTM.   The test with the CSS filter might flake on Mac Retina, due to too much
filter work to do.  One option would be to reduce the number of images filtered
in that test.  Anyho, thanks for re-enabling.

Powered by Google App Engine
This is Rietveld 408576698