Add WebVR device capability e2e test

Add WebVR device capability e2e test

Tests that the device capabilities reported by WebVR match expectations,
although currently all tested devices have the same expectations.

Automates one of our manual test cases.

BUG=702700
Review-Url: https://codereview.chromium.org/2794383002
Cr-Commit-Position: refs/heads/master@{#462934}
Committed: https://chromium.googlesource.com/chromium/src/+/d2bb15449ca92f88f8f4e9f6a93a96d567b00e2c

[bsheedy, 2017-04-04 16:31:13]

bsheedy@chromium.org changed reviewers:
+ nyquist@chromium.org

[bsheedy, 2017-04-04 16:31:13]

+nyquist for chrome/android/javatests OWNERS

[nyquist, 2017-04-04 19:07:42]

Did you only want me to review
chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java
?

Is there someone who are more familiar with the HTML+JS testing framework who
could review that part?

https://codereview.chromium.org/2794383002/diff/20001/chrome/test/data/androi...
File
chrome/test/data/android/webvr_instrumentation/html/test_device_capabilities_match_expectations.html
(right):

https://codereview.chromium.org/2794383002/diff/20001/chrome/test/data/androi...
chrome/test/data/android/webvr_instrumentation/html/test_device_capabilities_match_expectations.html:3:
Tests that the reported device capabilities match expectations
Nit, missing period.

https://codereview.chromium.org/2794383002/diff/20001/chrome/test/data/androi...
chrome/test/data/android/webvr_instrumentation/html/test_device_capabilities_match_expectations.html:27:
"angler": android_expectation, // Nexus 6P
Nit: Are comments different in JavaScript, or should there be two spaces before
// ?

[bsheedy, 2017-04-04 19:50:31]

bsheedy@chromium.org changed reviewers:
+ bajones@chromium.org

[bsheedy, 2017-04-04 19:50:32]

+bajones since he's more familiar with the testharness and spec.

Will still need an lgtm from nyquist@ on the Java portion, though.

https://codereview.chromium.org/2794383002/diff/20001/chrome/test/data/androi...
File
chrome/test/data/android/webvr_instrumentation/html/test_device_capabilities_match_expectations.html
(right):

https://codereview.chromium.org/2794383002/diff/20001/chrome/test/data/androi...
chrome/test/data/android/webvr_instrumentation/html/test_device_capabilities_match_expectations.html:3:
Tests that the reported device capabilities match expectations
On 2017/04/04 19:07:42, nyquist wrote:
> Nit, missing period.

Done.

https://codereview.chromium.org/2794383002/diff/20001/chrome/test/data/androi...
chrome/test/data/android/webvr_instrumentation/html/test_device_capabilities_match_expectations.html:27:
"angler": android_expectation, // Nexus 6P
On 2017/04/04 19:07:42, nyquist wrote:
> Nit: Are comments different in JavaScript, or should there be two spaces
before
> // ?

Done.

[nyquist, 2017-04-07 00:14:57]

//chrome/android/javatests lgtm

[bajones, 2017-04-07 17:05:37]

lgtm

[bsheedy, 2017-04-07 17:05:58]

The CQ bit was checked by bsheedy@chromium.org

[commit-bot: I haz the power, 2017-04-07 17:06:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 18:30:54]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491584758116880,
"parent_rev": "58eb768aa18cf83d0ac4b30d339ee1a778ee582a", "commit_rev":
"d2bb15449ca92f88f8f4e9f6a93a96d567b00e2c"}

[commit-bot: I haz the power, 2017-04-07 18:31:43]

Description was changed from

==========
Add WebVR device capability e2e test

Tests that the device capabilities reported by WebVR match expectations,
although currently all tested devices have the same expectations.

Automates one of our manual test cases.

BUG=702700
==========

to

==========
Add WebVR device capability e2e test

Tests that the device capabilities reported by WebVR match expectations,
although currently all tested devices have the same expectations.

Automates one of our manual test cases.

BUG=702700

Review-Url: https://codereview.chromium.org/2794383002
Cr-Commit-Position: refs/heads/master@{#462934}
Committed:
https://chromium.googlesource.com/chromium/src/+/d2bb15449ca92f88f8f4e9f6a93a...
==========

[commit-bot: I haz the power, 2017-04-07 18:31:44]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d2bb15449ca92f88f8f4e9f6a93a...