Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2794373002: VM [KERNEL] Use simpleInstanceOf in kernel. (Closed)

Created:
3 years, 8 months ago by Dmitry Olshansky
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -17 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M runtime/vm/kernel_to_il.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +3 lines, -0 lines 1 comment Download
M runtime/vm/object.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Dmitry Olshansky
3 years, 8 months ago (2017-04-04 15:25:57 UTC) #2
Vyacheslav Egorov (Google)
lgtm https://codereview.chromium.org/2794373002/diff/1/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/2794373002/diff/1/runtime/vm/object.h#newcode5889 runtime/vm/object.h:5889: bool simpleInstanceOfType(const AbstractType& type); We avoid using global ...
3 years, 8 months ago (2017-04-05 10:49:47 UTC) #3
Dmitry Olshansky
3 years, 8 months ago (2017-04-05 12:56:54 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ffc4c1df30dd5ecef087aaca60d8131cbb0aea2b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698