Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 2794373002: VM [KERNEL] Use simpleInstanceOf in kernel. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/kernel_to_il.cc » ('j') | runtime/vm/object.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc
index 46aeb72b2d2a968a766aca48655943621ce10861..7fee5f27e0f05cacbbbeeb8d1d66b211dc626c53 100644
--- a/runtime/vm/flow_graph_builder.cc
+++ b/runtime/vm/flow_graph_builder.cc
@@ -1487,23 +1487,6 @@ Value* EffectGraphVisitor::BuildAssignableValue(TokenPosition token_pos,
}
-static bool simpleInstanceOfType(const AbstractType& type) {
- // Bail if the type is still uninstantiated at compile time.
- if (!type.IsInstantiated()) return false;
-
- // Bail if the type is a function or a Dart Function type.
- if (type.IsFunctionType() || type.IsDartFunctionType()) return false;
-
- ASSERT(type.HasResolvedTypeClass());
- const Class& type_class = Class::Handle(type.type_class());
- // Bail if the type has any type parameters.
- if (type_class.IsGeneric()) return false;
-
- // Finally a simple class for instance of checking.
- return true;
-}
-
-
void EffectGraphVisitor::BuildTypeTest(ComparisonNode* node) {
ASSERT(Token::IsTypeTestOperator(node->kind()));
const AbstractType& type = node->right()->AsTypeNode()->type();
« no previous file with comments | « no previous file | runtime/vm/kernel_to_il.cc » ('j') | runtime/vm/object.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698