Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2794283004: Deselect disabled item for ItemChooserDialog on Android (Closed)

Created:
3 years, 8 months ago by juncai
Modified:
3 years, 8 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Deselect disabled item for ItemChooserDialog on Android When a selected item on ItemChooserDialog is disabled, it needs to be deselected. BUG=706700 Review-Url: https://codereview.chromium.org/2794283004 Cr-Commit-Position: refs/heads/master@{#462167} Committed: https://chromium.googlesource.com/chromium/src/+/bbe06a040450d03cda19e3fcec5e4d89948c7514

Patch Set 1 : deselect disabled item for ItemChooserDialog on Android #

Patch Set 2 : updated test code #

Total comments: 2

Patch Set 3 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java View 1 2 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 20 (15 generated)
juncai
Please take a look.
3 years, 8 months ago (2017-04-05 02:14:48 UTC) #6
Ted C
lgtm https://codereview.chromium.org/2794283004/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java File chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java (right): https://codereview.chromium.org/2794283004/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java#newcode270 chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java:270: if (id.equals(selectedRow.mKey)) { should this have a "&& ...
3 years, 8 months ago (2017-04-05 17:03:36 UTC) #9
juncai
https://codereview.chromium.org/2794283004/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java File chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java (right): https://codereview.chromium.org/2794283004/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java#newcode270 chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java:270: if (id.equals(selectedRow.mKey)) { On 2017/04/05 17:03:36, Ted C wrote: ...
3 years, 8 months ago (2017-04-05 19:01:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2794283004/40001
3 years, 8 months ago (2017-04-05 19:03:15 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 19:11:50 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bbe06a040450d03cda19e3fcec5e...

Powered by Google App Engine
This is Rietveld 408576698