Deselect disabled item for ItemChooserDialog on Android

Deselect disabled item for ItemChooserDialog on Android

When a selected item on ItemChooserDialog is disabled, it needs to be
deselected.

BUG=706700
Review-Url: https://codereview.chromium.org/2794283004
Cr-Commit-Position: refs/heads/master@{#462167}
Committed: https://chromium.googlesource.com/chromium/src/+/bbe06a040450d03cda19e3fcec5e4d89948c7514

[juncai, 2017-04-05 01:34:28]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 01:35:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2017-04-05 01:40:10]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 01:40:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2017-04-05 02:14:47]

juncai@chromium.org changed reviewers:
+ tedchoc@chromium.org

[juncai, 2017-04-05 02:14:48]

Please take a look.

[commit-bot: I haz the power, 2017-04-05 03:07:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 03:07:32]

Dry run: This issue passed the CQ dry run.

[Ted C, 2017-04-05 17:03:36]

lgtm

https://codereview.chromium.org/2794283004/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java
(right):

https://codereview.chromium.org/2794283004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java:270:
if (id.equals(selectedRow.mKey)) {
should this have a "&& !enabled" to be complete?

[juncai, 2017-04-05 17:56:28]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 17:56:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 18:51:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 18:51:34]

Dry run: This issue passed the CQ dry run.

[juncai, 2017-04-05 19:01:49]

https://codereview.chromium.org/2794283004/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java
(right):

https://codereview.chromium.org/2794283004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java:270:
if (id.equals(selectedRow.mKey)) {
On 2017/04/05 17:03:36, Ted C wrote:
> should this have a "&& !enabled" to be complete?

Done.

[juncai, 2017-04-05 19:01:53]

The CQ bit was checked by juncai@chromium.org

[juncai, 2017-04-05 19:01:53]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2794283004/#ps40001
(title: "address comment")

[commit-bot: I haz the power, 2017-04-05 19:03:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 19:11:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491418913506300,
"parent_rev": "5a9d9d9333295c2b73567e4256cd68abe5481380", "commit_rev":
"bbe06a040450d03cda19e3fcec5e4d89948c7514"}

[commit-bot: I haz the power, 2017-04-05 19:11:50]

Description was changed from

==========
Deselect disabled item for ItemChooserDialog on Android

When a selected item on ItemChooserDialog is disabled, it needs to be
deselected.

BUG=706700
==========

to

==========
Deselect disabled item for ItemChooserDialog on Android

When a selected item on ItemChooserDialog is disabled, it needs to be
deselected.

BUG=706700

Review-Url: https://codereview.chromium.org/2794283004
Cr-Commit-Position: refs/heads/master@{#462167}
Committed:
https://chromium.googlesource.com/chromium/src/+/bbe06a040450d03cda19e3fcec5e...
==========

[commit-bot: I haz the power, 2017-04-05 19:11:50]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bbe06a040450d03cda19e3fcec5e...