Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2794273002: Remove the argument of InputType::didSetValueByUserEdit(). (Closed)

Created:
3 years, 8 months ago by tkent
Modified:
3 years, 8 months ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the argument of InputType::didSetValueByUserEdit(). It's not referred. BUG=706370 Review-Url: https://codereview.chromium.org/2794273002 Cr-Commit-Position: refs/heads/master@{#461676} Committed: https://chromium.googlesource.com/chromium/src/+/9f98262f8933f8d050ad35f5327511a4d822904f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M third_party/WebKit/Source/core/html/forms/SearchInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/SearchInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextFieldInputType.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tkent
kochi@, would you review this please? Trivial code cleanup.
3 years, 8 months ago (2017-04-04 09:03:47 UTC) #5
kochi
lgtm rs lgtm
3 years, 8 months ago (2017-04-04 10:13:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2794273002/1
3 years, 8 months ago (2017-04-04 10:14:17 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 10:25:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9f98262f8933f8d050ad35f53275...

Powered by Google App Engine
This is Rietveld 408576698