|
|
Created:
3 years, 8 months ago by leonhsl(Using Gerrit) Modified:
3 years, 8 months ago CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove ScopedVector from chrome/installer/
base::ScopedVector is deprecated, see bug.
BUG=554289
Review-Url: https://codereview.chromium.org/2794263002
Cr-Commit-Position: refs/heads/master@{#462772}
Committed: https://chromium.googlesource.com/chromium/src/+/2baaba9891fafd293c619bdbcb70d2e083a76d86
Patch Set 1 : Remove ScopedVector from chrome/installer/ #Patch Set 2 : Remove ScopedVector from chrome/installer/ #
Total comments: 2
Patch Set 3 : #include <utility> #
Messages
Total messages: 39 (31 generated)
The CQ bit was checked by leon.han@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by leon.han@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by leon.han@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
leon.han@intel.com changed reviewers: + avi@chromium.org, gab@chromium.org
PTAL, Thanks.
LGTM though get gab's Windows approval too.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by leon.han@intel.com to run a CQ dry run
Patchset #1 (id:20001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by leon.han@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Sweet, lgtm, thanks! https://codereview.chromium.org/2794263002/diff/60001/chrome/installer/util/s... File chrome/installer/util/shell_util.cc (right): https://codereview.chromium.org/2794263002/diff/60001/chrome/installer/util/s... chrome/installer/util/shell_util.cc:399: std::move(delegate_execute_entries.begin(), delegate_execute_entries.end(), #include <utility>
Thanks all! Sending to CQ now. https://codereview.chromium.org/2794263002/diff/60001/chrome/installer/util/s... File chrome/installer/util/shell_util.cc (right): https://codereview.chromium.org/2794263002/diff/60001/chrome/installer/util/s... chrome/installer/util/shell_util.cc:399: std::move(delegate_execute_entries.begin(), delegate_execute_entries.end(), On 2017/04/06 15:00:54, gab (behind) wrote: > #include <utility> Done.
The CQ bit was checked by leon.han@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org, gab@chromium.org Link to the patchset: https://codereview.chromium.org/2794263002/#ps80001 (title: "#include <utility>")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by leon.han@intel.com
The CQ bit was checked by leon.han@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by leon.han@intel.com
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491541358906030, "parent_rev": "8b6a69f075e5f117b6a9df69cb42ebd6ffe52fa6", "commit_rev": "2baaba9891fafd293c619bdbcb70d2e083a76d86"}
The CQ bit was checked by leon.han@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org, gab@chromium.org Link to the patchset: https://codereview.chromium.org/2794263002/#ps100001 (title: "Rebase only")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove ScopedVector from chrome/installer/ base::ScopedVector is deprecated, see bug. BUG=554289 ========== to ========== Remove ScopedVector from chrome/installer/ base::ScopedVector is deprecated, see bug. BUG=554289 Review-Url: https://codereview.chromium.org/2794263002 Cr-Commit-Position: refs/heads/master@{#462772} Committed: https://chromium.googlesource.com/chromium/src/+/2baaba9891fafd293c619bdbcb70... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as https://chromium.googlesource.com/chromium/src/+/2baaba9891fafd293c619bdbcb70...
Message was sent while issue was closed.
Patchset #4 (id:100001) has been deleted |