Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2794263002: Remove ScopedVector from chrome/installer/ (Closed)

Created:
3 years, 8 months ago by leonhsl(Using Gerrit)
Modified:
3 years, 8 months ago
Reviewers:
Avi (use Gerrit), gab
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector from chrome/installer/ base::ScopedVector is deprecated, see bug. BUG=554289 Review-Url: https://codereview.chromium.org/2794263002 Cr-Commit-Position: refs/heads/master@{#462772} Committed: https://chromium.googlesource.com/chromium/src/+/2baaba9891fafd293c619bdbcb70d2e083a76d86

Patch Set 1 : Remove ScopedVector from chrome/installer/ #

Patch Set 2 : Remove ScopedVector from chrome/installer/ #

Total comments: 2

Patch Set 3 : #include <utility> #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -124 lines) Patch
M chrome/installer/util/scoped_user_protocol_entry.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/installer/util/scoped_user_protocol_entry.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/util/scoped_user_protocol_entry_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/shell_util.h View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 1 2 27 chunks +134 lines, -116 lines 0 comments Download

Messages

Total messages: 39 (31 generated)
leonhsl(Using Gerrit)
PTAL, Thanks.
3 years, 8 months ago (2017-04-05 02:57:10 UTC) #11
Avi (use Gerrit)
LGTM though get gab's Windows approval too.
3 years, 8 months ago (2017-04-05 03:03:20 UTC) #12
gab
Sweet, lgtm, thanks! https://codereview.chromium.org/2794263002/diff/60001/chrome/installer/util/shell_util.cc File chrome/installer/util/shell_util.cc (right): https://codereview.chromium.org/2794263002/diff/60001/chrome/installer/util/shell_util.cc#newcode399 chrome/installer/util/shell_util.cc:399: std::move(delegate_execute_entries.begin(), delegate_execute_entries.end(), #include <utility>
3 years, 8 months ago (2017-04-06 15:00:54 UTC) #24
leonhsl(Using Gerrit)
Thanks all! Sending to CQ now. https://codereview.chromium.org/2794263002/diff/60001/chrome/installer/util/shell_util.cc File chrome/installer/util/shell_util.cc (right): https://codereview.chromium.org/2794263002/diff/60001/chrome/installer/util/shell_util.cc#newcode399 chrome/installer/util/shell_util.cc:399: std::move(delegate_execute_entries.begin(), delegate_execute_entries.end(), On ...
3 years, 8 months ago (2017-04-07 01:45:48 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2794263002/80001
3 years, 8 months ago (2017-04-07 01:47:10 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2794263002/80001
3 years, 8 months ago (2017-04-07 05:03:13 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2794263002/100001
3 years, 8 months ago (2017-04-07 05:34:27 UTC) #36
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 05:34:33 UTC) #38
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/2baaba9891fafd293c619bdbcb70...

Powered by Google App Engine
This is Rietveld 408576698