Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: src/objects-visiting-inl.h

Issue 279423005: Customized support for feedback on calls to Array. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects-visiting-inl.h
diff --git a/src/objects-visiting-inl.h b/src/objects-visiting-inl.h
index bb2e99243a1d72bf318e246a14e34b1665f2b3cc..498b517e7f28d7d7e9fc860ccd4decada05dbd3e 100644
--- a/src/objects-visiting-inl.h
+++ b/src/objects-visiting-inl.h
@@ -287,9 +287,15 @@ void StaticMarkingVisitor<StaticVisitor>::VisitCodeTarget(
// when they might be keeping a Context alive, or when the heap is about
// to be serialized.
+ // TODO(mvstanton): CALL_IC in monomorphic state needs to be cleared because
+ // it's state is synced with a type feedback slot, which is always cleared on
+ // gc. If we leave it alone, we'll end up in a hybrid of (cleared feedback
+ // slot but monomorphic IC), which is complex.
if (FLAG_cleanup_code_caches_at_gc && target->is_inline_cache_stub()
&& (target->ic_state() == MEGAMORPHIC || target->ic_state() == GENERIC ||
target->ic_state() == POLYMORPHIC || heap->flush_monomorphic_ics() ||
+ (target->ic_state() == MONOMORPHIC &&
+ target->kind() == Code::CALL_IC) ||
danno 2014/05/16 16:34:11 This code can be removed.
mvstanton 2014/05/19 13:45:24 Done.
Serializer::enabled(heap->isolate()) ||
target->ic_age() != heap->global_ic_age() ||
target->is_invalidated_weak_stub())) {

Powered by Google App Engine
This is Rietveld 408576698