Customized support for feedback on calls to Array.

src/objects-visiting-inl.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_OBJECTS_VISITING_INL_H_
 #define V8_OBJECTS_VISITING_INL_H_
 
 
 namespace v8 {
 namespace internal {
@@ skipping 269 matching lines @@
 
 template<typename StaticVisitor>
 void StaticMarkingVisitor<StaticVisitor>::VisitCodeTarget(
     Heap* heap, RelocInfo* rinfo) {
   ASSERT(RelocInfo::IsCodeTarget(rinfo->rmode()));
   Code* target = Code::GetCodeFromTargetAddress(rinfo->target_address());
   // Monomorphic ICs are preserved when possible, but need to be flushed
   // when they might be keeping a Context alive, or when the heap is about
   // to be serialized.
 
+  // TODO(mvstanton): CALL_IC in monomorphic state needs to be cleared because
+  // it's state is synced with a type feedback slot, which is always cleared on
+  // gc. If we leave it alone, we'll end up in a hybrid of (cleared feedback
+  // slot but monomorphic IC), which is complex.
   if (FLAG_cleanup_code_caches_at_gc && target->is_inline_cache_stub()
       && (target->ic_state() == MEGAMORPHIC || target->ic_state() == GENERIC ||
           target->ic_state() == POLYMORPHIC || heap->flush_monomorphic_ics() ||
+          (target->ic_state() == MONOMORPHIC &&
+           target->kind() == Code::CALL_IC) ||

[danno, 2014/05/16 16:34:11]

This code can be removed.

[mvstanton, 2014/05/19 13:45:24]

Done.

           Serializer::enabled(heap->isolate()) ||
           target->ic_age() != heap->global_ic_age() ||
           target->is_invalidated_weak_stub())) {
     IC::Clear(heap->isolate(), rinfo->pc(), rinfo->host()->constant_pool());
     target = Code::GetCodeFromTargetAddress(rinfo->target_address());
   }
   heap->mark_compact_collector()->RecordRelocSlot(rinfo, target);
   StaticVisitor::MarkObject(heap, target);
 }
 
@@ skipping 629 matching lines @@
   RelocIterator it(this, mode_mask);
   for (; !it.done(); it.next()) {
     it.rinfo()->template Visit<StaticVisitor>(heap);
   }
 }
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_OBJECTS_VISITING_INL_H_