Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2794183004: Fix -Wsign-compare in l10n_string_util_unittest.cc (Closed)

Created:
3 years, 8 months ago by hans
Modified:
3 years, 8 months ago
Reviewers:
grt, grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, jshin+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix -Wsign-compare in l10n_string_util_unittest.cc Clang builds were failing with: C:\b\c\b\ClangToTWin\src\testing\gtest\include\gtest\gtest.h(1392,16): error: comparison of integers of different signs: 'const int' and 'const unsigned int' [-Werror,-Wsign-compare] if (expected == actual) { ~~~~~~~~ ^ ~~~~~~ BUG=708178 TBR=grt Review-Url: https://codereview.chromium.org/2794183004 Cr-Commit-Position: refs/heads/master@{#461742} Committed: https://chromium.googlesource.com/chromium/src/+/77b4b28f7866f526a13426dd5c5ca2e8f0156c7a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/installer/util/l10n_string_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
hans
tbr'ing to unbreak all win-clang buildbots
3 years, 8 months ago (2017-04-04 16:10:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2794183004/1
3 years, 8 months ago (2017-04-04 16:11:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/77b4b28f7866f526a13426dd5c5ca2e8f0156c7a
3 years, 8 months ago (2017-04-04 16:29:24 UTC) #6
grt (UTC plus 2)
3 years, 8 months ago (2017-04-05 07:32:07 UTC) #8
Message was sent while issue was closed.
lgtm, thanks.

Powered by Google App Engine
This is Rietveld 408576698