Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(239)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/browser/notifications/OWNERS
Issue
2794103002
:
Add initial support for native Linux desktop notifications (Closed)
Patch Set: Refactor, move impl to chrome/browser/notifications
Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/BUILD.gn
chrome/browser/about_flags.cc
chrome/browser/flag_descriptions.h
chrome/browser/flag_descriptions.cc
chrome/browser/notifications/OWNERS
chrome/browser/notifications/dbus_notification_manager.h
chrome/browser/notifications/dbus_notification_manager.cc
chrome/browser/notifications/message_center_notification_manager.h
chrome/browser/notifications/message_center_notification_manager.cc
chrome/common/chrome_switches.h
chrome/common/chrome_switches.cc
View unified diff
|
Download patch
« chrome/browser/about_flags.cc
('K') |
« chrome/browser/flag_descriptions.cc
('k') |
chrome/browser/notifications/dbus_notification_manager.h »
('j') |
chrome/browser/notifications/dbus_notification_manager.cc »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 dewittj@chromium.org
1 dewittj@chromium.org
2 dimich@chromium.org
2 dimich@chromium.org
3 miguelg@chromium.org
3 miguelg@chromium.org
4 mukai@chromium.org
4 mukai@chromium.org
5 peter@chromium.org
5 peter@chromium.org
6 stevenjb@chromium.org
6 stevenjb@chromium.org
7 yoshiki@chromium.org
7 yoshiki@chromium.org
8
8
9 # Mac files
9 # Mac files
10 per-file *_mac*=rsesek@chromium.org
10 per-file *_mac*=rsesek@chromium.org
11
11
12
# Linux files
13
per-file dbus_notification_manager*=thestig@chromium.org
14
per-file dbus_notification_manager*=thomasanderson@chromium.org
15
12 # TEAM: platform-capabilities@chromium.org
16 # TEAM: platform-capabilities@chromium.org
13 # COMPONENT: UI>Notifications
17 # COMPONENT: UI>Notifications
OLD
NEW
« chrome/browser/about_flags.cc
('K') |
« chrome/browser/flag_descriptions.cc
('k') |
chrome/browser/notifications/dbus_notification_manager.h »
('j') |
chrome/browser/notifications/dbus_notification_manager.cc »
('J')
Issue 2794103002: Add initial support for native Linux desktop notifications (Closed)
Created 3 years, 8 months ago by Tom (Use chromium acct)
Modified 3 years, 8 months ago
Reviewers: Lei Zhang, Peter Beverloo
Base URL:
Comments: 33
This is Rietveld
408576698