Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2794103002: Add initial support for native Linux desktop notifications (Closed)
Patch Set: Refactor, move impl to chrome/browser/notifications Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 2467 matching lines...) Expand 10 before | Expand all | Expand 10 after
2478 flag_descriptions::kUseNewDoodleApiDescription, kOsAndroid, 2478 flag_descriptions::kUseNewDoodleApiDescription, kOsAndroid,
2479 FEATURE_VALUE_TYPE(chrome::android::kUseNewDoodleApi)}, 2479 FEATURE_VALUE_TYPE(chrome::android::kUseNewDoodleApi)},
2480 #endif // OS_ANDROID 2480 #endif // OS_ANDROID
2481 2481
2482 {"delay-navigation", flag_descriptions::kDelayNavigationName, 2482 {"delay-navigation", flag_descriptions::kDelayNavigationName,
2483 flag_descriptions::kDelayNavigationDescription, kOsAll, 2483 flag_descriptions::kDelayNavigationDescription, kOsAll,
2484 FEATURE_WITH_PARAMS_VALUE_TYPE(kDelayNavigationFeature, 2484 FEATURE_WITH_PARAMS_VALUE_TYPE(kDelayNavigationFeature,
2485 kDelayNavigationFeatureVariations, 2485 kDelayNavigationFeatureVariations,
2486 "DelayNavigation")}, 2486 "DelayNavigation")},
2487 2487
2488 #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
2489 {"use-system-notifications", flag_descriptions::kUseSystemNotificationsName,
Peter Beverloo 2017/04/03 23:39:29 Can you reuse "enable-native-notifications" (alrea
Tom (Use chromium acct) 2017/04/04 02:43:16 Done.
2490 flag_descriptions::kUseSystemNotificationsDescription, kOsLinux,
2491 SINGLE_VALUE_TYPE(switches::kUseSystemNotifications)},
2492 #endif
2493
2488 // NOTE: Adding new command-line switches requires adding corresponding 2494 // NOTE: Adding new command-line switches requires adding corresponding
2489 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2495 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2490 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2496 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2491 }; 2497 };
2492 2498
2493 class FlagsStateSingleton { 2499 class FlagsStateSingleton {
2494 public: 2500 public:
2495 FlagsStateSingleton() 2501 FlagsStateSingleton()
2496 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} 2502 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
2497 ~FlagsStateSingleton() {} 2503 ~FlagsStateSingleton() {}
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
2686 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2692 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2687 2693
2688 const FeatureEntry* GetFeatureEntries(size_t* count) { 2694 const FeatureEntry* GetFeatureEntries(size_t* count) {
2689 *count = arraysize(kFeatureEntries); 2695 *count = arraysize(kFeatureEntries);
2690 return kFeatureEntries; 2696 return kFeatureEntries;
2691 } 2697 }
2692 2698
2693 } // namespace testing 2699 } // namespace testing
2694 2700
2695 } // namespace about_flags 2701 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698