Use commitAllowingStateLoss() for showing sync confirmation dialogs

Use commitAllowingStateLoss() for showing sync confirmation dialogs

This CL fixes crash that is caused by asynchronous callback trying to show
dialog after activity was paused.
Android framework doesn't allow committing FragmentTransactions after call to
onSaveInstanceState, because such transactions can lead to state loss if activity
is killed and recreated from the earlier saved state. This CL uses
commitAllowingStateLoss() to avoid exception and crash. Possible state loss
is not important in this case because of crbug.com/708156.

BUG=672251
Review-Url: https://codereview.chromium.org/2794063004
Cr-Commit-Position: refs/heads/master@{#462814}
Committed: https://chromium.googlesource.com/chromium/src/+/7b9f72c29d6da03e50bc77c127f76a6a2d38477e

[bsazonov, 2017-04-04 14:32:49]

The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 14:33:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 15:08:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 15:08:39]

Dry run: This issue passed the CQ dry run.

[bsazonov, 2017-04-04 16:46:58]

bsazonov@chromium.org changed reviewers:
+ nyquist@chromium.org

[bsazonov, 2017-04-04 16:46:59]

Tommy, please take a look.

[nyquist, 2017-04-06 23:22:01]

lgtm

[bsazonov, 2017-04-07 08:24:26]

The CQ bit was checked by bsazonov@chromium.org

[commit-bot: I haz the power, 2017-04-07 08:24:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 09:01:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491553466493700, "parent_rev":
"95e17ac4602dc38aaa6a44d4f6d2566920d6c75d", "commit_rev":
"7b9f72c29d6da03e50bc77c127f76a6a2d38477e"}

[commit-bot: I haz the power, 2017-04-07 09:02:42]

Description was changed from

==========
Use commitAllowingStateLoss() for showing sync confirmation dialogs

This CL fixes crash that is caused by asynchronous callback trying to show
dialog after activity was paused.
Android framework doesn't allow committing FragmentTransactions after call to
onSaveInstanceState, because such transactions can lead to state loss if
activity
is killed and recreated from the earlier saved state. This CL uses
commitAllowingStateLoss() to avoid exception and crash. Possible state loss
is not important in this case because of crbug.com/708156.

BUG=672251
==========

to

==========
Use commitAllowingStateLoss() for showing sync confirmation dialogs

This CL fixes crash that is caused by asynchronous callback trying to show
dialog after activity was paused.
Android framework doesn't allow committing FragmentTransactions after call to
onSaveInstanceState, because such transactions can lead to state loss if
activity
is killed and recreated from the earlier saved state. This CL uses
commitAllowingStateLoss() to avoid exception and crash. Possible state loss
is not important in this case because of crbug.com/708156.

BUG=672251

Review-Url: https://codereview.chromium.org/2794063004
Cr-Commit-Position: refs/heads/master@{#462814}
Committed:
https://chromium.googlesource.com/chromium/src/+/7b9f72c29d6da03e50bc77c127f7...
==========

[commit-bot: I haz the power, 2017-04-07 09:02:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7b9f72c29d6da03e50bc77c127f7...