Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2794013006: DevTools: Run snippet QuickOpen (Closed)

Created:
3 years, 8 months ago by einbinder
Modified:
3 years, 8 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Run snippet QuickOpen This adds the ability to run snippets in QuickOpen by using '!' BUG=662081 Review-Url: https://codereview.chromium.org/2794013006 Cr-Commit-Position: refs/heads/master@{#462362} Committed: https://chromium.googlesource.com/chromium/src/+/13a036338d78a0ff95e285300e39dceb06a04e39

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/snippets/SnippetsQuickOpen.js View 1 chunk +77 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/snippets/module.json View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
einbinder
ptal
3 years, 8 months ago (2017-04-05 01:16:20 UTC) #2
pfeldman
This looks awesome
3 years, 8 months ago (2017-04-05 01:20:33 UTC) #3
pfeldman
lgtm
3 years, 8 months ago (2017-04-05 21:10:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2794013006/1
3 years, 8 months ago (2017-04-05 21:39:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/416041)
3 years, 8 months ago (2017-04-06 00:03:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2794013006/1
3 years, 8 months ago (2017-04-06 03:31:32 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 05:28:04 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/13a036338d78a0ff95e285300e39...

Powered by Google App Engine
This is Rietveld 408576698