Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2793943002: Fix disassembly of OSR functions. (Closed)

Created:
3 years, 8 months ago by erikcorry
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix disassembly of OSR functions. This got broken when I changed the compiler to not install OSR code on the function, where it had to be immediately uninstalled again. R=vegorov@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1f1854aa78f5fba1c25964d1ae9995f5c81b9a01

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unused function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -19 lines) Patch
M runtime/vm/compiler.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M runtime/vm/disassembler.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/disassembler.cc View 1 1 chunk +3 lines, -10 lines 0 comments Download
M runtime/vm/precompiler.cc View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
erikcorry
3 years, 8 months ago (2017-04-03 13:45:33 UTC) #1
Vyacheslav Egorov (Google)
lgtm https://codereview.chromium.org/2793943002/diff/1/runtime/vm/disassembler.h File runtime/vm/disassembler.h (right): https://codereview.chromium.org/2793943002/diff/1/runtime/vm/disassembler.h#newcode140 runtime/vm/disassembler.h:140: static void DisassembleCodeUnoptimized(const Function& function, I think this ...
3 years, 8 months ago (2017-04-03 15:11:28 UTC) #2
erikcorry
Committed patchset #2 (id:20001) manually as 1f1854aa78f5fba1c25964d1ae9995f5c81b9a01 (presubmit successful).
3 years, 8 months ago (2017-04-03 15:29:46 UTC) #4
erikcorry
3 years, 8 months ago (2017-04-03 15:38:34 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/2793943002/diff/1/runtime/vm/disassembler.h
File runtime/vm/disassembler.h (right):

https://codereview.chromium.org/2793943002/diff/1/runtime/vm/disassembler.h#n...
runtime/vm/disassembler.h:140: static void DisassembleCodeUnoptimized(const
Function& function,
On 2017/04/03 15:11:28, Vyacheslav Egorov (Google) wrote:
> I think this function is dead, so maybe delete it while you are here?

Done.

Powered by Google App Engine
This is Rietveld 408576698