Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: runtime/vm/disassembler.h

Issue 2793943002: Fix disassembly of OSR functions. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/disassembler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef RUNTIME_VM_DISASSEMBLER_H_ 5 #ifndef RUNTIME_VM_DISASSEMBLER_H_
6 #define RUNTIME_VM_DISASSEMBLER_H_ 6 #define RUNTIME_VM_DISASSEMBLER_H_
7 7
8 #include "vm/allocation.h" 8 #include "vm/allocation.h"
9 #include "vm/assembler.h" 9 #include "vm/assembler.h"
10 #include "vm/globals.h" 10 #include "vm/globals.h"
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 // Writes the length of the decoded instruction in bytes in out_instr_len. 127 // Writes the length of the decoded instruction in bytes in out_instr_len.
128 static void DecodeInstruction(char* hex_buffer, 128 static void DecodeInstruction(char* hex_buffer,
129 intptr_t hex_size, 129 intptr_t hex_size,
130 char* human_buffer, 130 char* human_buffer,
131 intptr_t human_size, 131 intptr_t human_size,
132 int* out_instr_len, 132 int* out_instr_len,
133 const Code& code, 133 const Code& code,
134 Object** object, 134 Object** object,
135 uword pc); 135 uword pc);
136 136
137 static void DisassembleCode(const Function& function, bool optimized); 137 static void DisassembleCode(const Function& function,
138 const Code& code,
139 bool optimized);
138 static void DisassembleCodeUnoptimized(const Function& function, 140 static void DisassembleCodeUnoptimized(const Function& function,
Vyacheslav Egorov (Google) 2017/04/03 15:11:28 I think this function is dead, so maybe delete it
erikcorry 2017/04/03 15:38:34 Done.
139 bool optimized); 141 bool optimized);
140 142
141 private: 143 private:
142 static void DisassembleCodeHelper(const char* function_fullname, 144 static void DisassembleCodeHelper(const char* function_fullname,
143 const Code& code, 145 const Code& code,
144 bool optimized); 146 bool optimized);
145 147
146 static const int kHexadecimalBufferSize = 32; 148 static const int kHexadecimalBufferSize = 32;
147 static const int kUserReadableBufferSize = 256; 149 static const int kUserReadableBufferSize = 256;
148 }; 150 };
149 151
150 } // namespace dart 152 } // namespace dart
151 153
152 #endif // RUNTIME_VM_DISASSEMBLER_H_ 154 #endif // RUNTIME_VM_DISASSEMBLER_H_
OLDNEW
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/disassembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698