Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2793933002: Move styleMap attribute from HTMLElement to Element (Closed)

Created:
3 years, 8 months ago by Shanmuga Pandi
Modified:
3 years, 8 months ago
Reviewers:
meade_UTC10, fs, foolip
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move styleMap attribute from HTMLElement to Element As per spec, moving styleMap from HTMLElement to Element. https://drafts.css-houdini.org/css-typed-om/#inline-stylepropertymap-objects BUG=695597 Review-Url: https://codereview.chromium.org/2793933002 Cr-Commit-Position: refs/heads/master@{#461632} Committed: https://chromium.googlesource.com/chromium/src/+/559bf6dabe17e1966e038175d43590cee78d6664

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.idl View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.idl View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Shanmuga Pandi
PTAL!!
3 years, 8 months ago (2017-04-03 13:10:02 UTC) #2
fs
This looks good to me, but given it's an experimental feature, it's probably good to ...
3 years, 8 months ago (2017-04-03 13:21:44 UTC) #6
meade_UTC10
lgtm
3 years, 8 months ago (2017-04-03 23:52:42 UTC) #9
foolip
lgtm
3 years, 8 months ago (2017-04-04 04:21:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793933002/1
3 years, 8 months ago (2017-04-04 04:47:10 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 04:52:01 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/559bf6dabe17e1966e038175d435...

Powered by Google App Engine
This is Rietveld 408576698