Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 2793913003: Fix bug in telemetry benchmark script (Closed)

Created:
3 years, 8 months ago by martiniss
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix bug in telemetry benchmark script It appears that some test data json doesn't necessarily have a name. Fallback on the url if this is the case. Review-Url: https://codereview.chromium.org/2793913003 Cr-Commit-Position: refs/heads/master@{#461598} Committed: https://chromium.googlesource.com/chromium/src/+/be66fed8cd273727437c2bfc1cf5952eba00959e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M testing/scripts/run_telemetry_benchmark_as_googletest.py View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
martiniss
PTAL
3 years, 8 months ago (2017-04-03 20:04:17 UTC) #2
martiniss
This should help with the exceptions at the bottom of tasks like https://chromium-swarm.appspot.com/task?id=354ba688bf954a10&refresh=10&show_raw=1
3 years, 8 months ago (2017-04-03 20:04:31 UTC) #3
Ken Russell (switch to Gerrit)
lgtm Thanks for fixing this Stephen. +nednguyen as FYI; Speed team is the real owner ...
3 years, 8 months ago (2017-04-03 20:20:03 UTC) #4
martiniss
Oh whoops, meant to set him as reviewer. Thanks for the review anyways!
3 years, 8 months ago (2017-04-03 20:44:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793913003/1
3 years, 8 months ago (2017-04-03 20:45:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/422339)
3 years, 8 months ago (2017-04-03 23:16:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793913003/1
3 years, 8 months ago (2017-04-03 23:18:31 UTC) #11
Ken Russell (switch to Gerrit)
On 2017/04/03 23:16:44, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 8 months ago (2017-04-03 23:49:06 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/be66fed8cd273727437c2bfc1cf5952eba00959e
3 years, 8 months ago (2017-04-04 01:22:58 UTC) #15
nednguyen
3 years, 8 months ago (2017-04-04 13:10:41 UTC) #16
Message was sent while issue was closed.
On 2017/04/04 01:22:58, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/be66fed8cd273727437c2bfc1cf5...

Thanks Stephen, the fix is now working!
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Win%2010%20High...

However, in the future, please file a bug to keep track the process of fixing
bug & verify the fix in production,

Powered by Google App Engine
This is Rietveld 408576698