Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 2793903005: cros: manual tweaks to network off badge (strikethrough) (Closed)

Created:
3 years, 8 months ago by Evan Stade
Modified:
3 years, 8 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: manual tweaks to network off badge (strikethrough) BUG=702855 Review-Url: https://codereview.chromium.org/2793903005 Cr-Commit-Position: refs/heads/master@{#461777} Committed: https://chromium.googlesource.com/chromium/src/+/0e7814d516c002db64d75bad3d519740a266dd54

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M ash/resources/vector_icons/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ash/resources/vector_icons/network_badge_off.icon View 1 chunk +7 lines, -8 lines 0 comments Download
A + ash/resources/vector_icons/network_badge_off.1x.icon View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Evan Stade
3 years, 8 months ago (2017-04-04 03:32:10 UTC) #2
tdanderson
lgtm
3 years, 8 months ago (2017-04-04 15:01:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793903005/1
3 years, 8 months ago (2017-04-04 15:03:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/421346)
3 years, 8 months ago (2017-04-04 16:21:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793903005/1
3 years, 8 months ago (2017-04-04 17:08:38 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 18:28:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0e7814d516c002db64d75bad3d51...

Powered by Google App Engine
This is Rietveld 408576698