Descriptionbase: CommandLineFlags.Add need to parse out value
This is probably source of flakes where tests use
@CommandLineFlags.Add("foo=bar"). Before this CL, the entire "foo=bar"
string is used as the switch, and a value of null, but only if the
java-only CommandLine instance is in use. So if any test tries to read
the switch during start up, it's racy.
Fix by parsing the command line in CommandLineFlags.
BUG=689758
Review-Url: https://codereview.chromium.org/2793903003
Cr-Commit-Position: refs/heads/master@{#461534}
Committed: https://chromium.googlesource.com/chromium/src/+/2b2e80acce1c253615137ccdd101e6c390458d23
Patch Set 1 #
Total comments: 3
Patch Set 2 : split(2) #Messages
Total messages: 12 (7 generated)
|