base: CommandLineFlags.Add need to parse out value

base: CommandLineFlags.Add need to parse out value

This is probably source of flakes where tests use
@CommandLineFlags.Add("foo=bar"). Before this CL, the entire "foo=bar"
string is used as the switch, and a value of null, but only if the
java-only CommandLine instance is in use. So if any test tries to read
the switch during start up, it's racy.

Fix by parsing the command line in CommandLineFlags.

BUG=689758
Review-Url: https://codereview.chromium.org/2793903003
Cr-Commit-Position: refs/heads/master@{#461534}
Committed: https://chromium.googlesource.com/chromium/src/+/2b2e80acce1c253615137ccdd101e6c390458d23

[boliu, 2017-04-03 18:28:48]

The CQ bit was checked by boliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 18:30:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2017-04-03 18:31:50]

boliu@chromium.org changed reviewers:
+ jbudorick@chromium.org

[boliu, 2017-04-03 18:31:50]

ptal

found this issue from https://codereview.chromium.org/2792873003/

[jbudorick, 2017-04-03 19:11:51]

lgtm w/ nit

https://codereview.chromium.org/2793903003/diff/1/base/test/android/javatests...
File
base/test/android/javatests/src/org/chromium/base/test/util/CommandLineFlags.java
(right):

https://codereview.chromium.org/2793903003/diff/1/base/test/android/javatests...
base/test/android/javatests/src/org/chromium/base/test/util/CommandLineFlags.java:75:
String[] parsedFlags = flag.split("=");
nit: split("=", 2) ?

https://codereview.chromium.org/2793903003/diff/1/base/test/android/javatests...
base/test/android/javatests/src/org/chromium/base/test/util/CommandLineFlags.java:80:
CommandLine.getInstance().appendSwitchWithValue(parsedFlags[0], value);
w/ split("=", 2), this block could just be

  CommandLine.getInstance().appendSwitchWithValue(parsedFlags[0],
parsedFlags[1]);

[boliu, 2017-04-03 19:40:43]

https://codereview.chromium.org/2793903003/diff/1/base/test/android/javatests...
File
base/test/android/javatests/src/org/chromium/base/test/util/CommandLineFlags.java
(right):

https://codereview.chromium.org/2793903003/diff/1/base/test/android/javatests...
base/test/android/javatests/src/org/chromium/base/test/util/CommandLineFlags.java:75:
String[] parsedFlags = flag.split("=");
On 2017/04/03 19:11:51, jbudorick wrote:
> nit: split("=", 2) ?

oh cool, done

[boliu, 2017-04-03 19:40:47]

The CQ bit was checked by boliu@chromium.org

[boliu, 2017-04-03 19:40:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/2793903003/#ps20001
(title: "split(2)")

[commit-bot: I haz the power, 2017-04-03 19:41:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 21:00:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491248447069310,
"parent_rev": "ae7fc3094d50f04c513f4b62c5f45475cbba17f5", "commit_rev":
"2b2e80acce1c253615137ccdd101e6c390458d23"}

[commit-bot: I haz the power, 2017-04-03 21:01:40]

Description was changed from

==========
base: CommandLineFlags.Add need to parse out value

This is probably source of flakes where tests use
@CommandLineFlags.Add("foo=bar"). Before this CL, the entire "foo=bar"
string is used as the switch, and a value of null, but only if the
java-only CommandLine instance is in use. So if any test tries to read
the switch during start up, it's racy.

Fix by parsing the command line in CommandLineFlags.

BUG=689758
==========

to

==========
base: CommandLineFlags.Add need to parse out value

This is probably source of flakes where tests use
@CommandLineFlags.Add("foo=bar"). Before this CL, the entire "foo=bar"
string is used as the switch, and a value of null, but only if the
java-only CommandLine instance is in use. So if any test tries to read
the switch during start up, it's racy.

Fix by parsing the command line in CommandLineFlags.

BUG=689758

Review-Url: https://codereview.chromium.org/2793903003
Cr-Commit-Position: refs/heads/master@{#461534}
Committed:
https://chromium.googlesource.com/chromium/src/+/2b2e80acce1c253615137ccdd101...
==========

[commit-bot: I haz the power, 2017-04-03 21:01:41]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2b2e80acce1c253615137ccdd101...