Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 2793873002: DevTools: Update CommandMenuProvider on attach instead of construction (Closed)

Created:
3 years, 8 months ago by einbinder
Modified:
3 years, 8 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Update CommandMenuProvider on attach instead of construction The CommandMenu was only updating avaiable actions on construction. This could cause a scenario where actions from a stale context were visible. BUG=662081 Review-Url: https://codereview.chromium.org/2793873002 Cr-Commit-Position: refs/heads/master@{#461993} Committed: https://chromium.googlesource.com/chromium/src/+/d8cdcf7426f5c765161a2ba97d69a10b55e8624f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/quick_open/CommandMenu.js View 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
einbinder
ptal
3 years, 8 months ago (2017-04-03 05:08:07 UTC) #2
pfeldman
lgtm
3 years, 8 months ago (2017-04-04 20:21:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793873002/1
3 years, 8 months ago (2017-04-04 22:12:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793873002/1
3 years, 8 months ago (2017-04-05 05:00:23 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 06:47:53 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d8cdcf7426f5c765161a2ba97d69...

Powered by Google App Engine
This is Rietveld 408576698