Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2793853002: Implement TOGGLE_EXPANSION action for the ARC notifications. (Closed)

Created:
3 years, 8 months ago by yhanada
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Implement TOGGLE_EXPANSION action for the ARC notifications. TOGGLE_EXPANSION action will be triggerred when a user triggers DO_DEFAULT accessibility action on the notification. I use the target of the mouse pressing event on ArcCustomNotificationView to distinguish accessibility DO_DEFAULT action and normal click on the notification. This hack will be removed after making |AXActionData| be propagated to |HandleAccessibleAction|. BUG=703989 Review-Url: https://codereview.chromium.org/2767253005 Cr-Commit-Position: refs/heads/master@{#460087} (cherry picked from commit b7af49bce7ecd2e79c8a54712d27bd45e27c2420) Review-Url: https://codereview.chromium.org/2793853002 . Cr-Commit-Position: refs/branch-heads/3029@{#538} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/03873abfe51c7da3dd502d3addd309c1c1a74697

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
M ui/arc/notification/arc_custom_notification_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/arc/notification/arc_custom_notification_view.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M ui/arc/notification/arc_notification_item.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/arc/notification/arc_notification_item.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/arc/notification/arc_notification_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/arc/notification/arc_notification_manager.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M ui/message_center/views/custom_notification_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/message_center/views/custom_notification_view.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
yhanada
3 years, 8 months ago (2017-04-03 02:02:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
03873abfe51c7da3dd502d3addd309c1c1a74697.

Powered by Google App Engine
This is Rietveld 408576698