Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 2793803002: Remove ScopedAllowCrossThreadRefCountAccess from GpuDataManagerImpl (Closed)

Created:
3 years, 8 months ago by tzik
Modified:
3 years, 8 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedAllowCrossThreadRefCountAccess from GpuDataManagerImpl ScopedAllowCrossThreadRefCountAccess here has suppressed an assertion hit in a RefCount manipulation done by GpuControlListEntry. Since it's no longer RefCounted class after http://crrev.com/2756793003, the suppression is no longer needed. BUG=688072 Review-Url: https://codereview.chromium.org/2793803002 Cr-Commit-Position: refs/heads/master@{#461469} Committed: https://chromium.googlesource.com/chromium/src/+/2e3a439966819d6ce1700f01e76cc671276c40a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M content/browser/gpu/gpu_data_manager_impl.cc View 3 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
tzik
PTAL
3 years, 8 months ago (2017-04-03 00:51:18 UTC) #8
Zhenyao Mo
lgtm
3 years, 8 months ago (2017-04-03 15:49:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793803002/1
3 years, 8 months ago (2017-04-03 16:18:31 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 18:07:11 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2e3a439966819d6ce1700f01e76c...

Powered by Google App Engine
This is Rietveld 408576698