Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2793733002: s/samePage/sameDocument in navigation_metrics_unittest.cc. (Closed)

Created:
3 years, 8 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 8 months ago
Reviewers:
davidben
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SameDocument term in navigation metrics unittest. Old name was presumably used to match was_within_same_page IPC, but SameDocument name better reflects the the type of the navigation (navigation did not change the document object). This change will make naming more consistent with the rest of Chromium code. BUG=695189 Review-Url: https://codereview.chromium.org/2793733002 Cr-Commit-Position: refs/heads/master@{#461549} Committed: https://chromium.googlesource.com/chromium/src/+/0b9db8c1ccf56746c5046b0ce7325d572d8d11c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/navigation_metrics/navigation_metrics_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Eugene But (OOO till 7-30)
PTAL
3 years, 8 months ago (2017-04-01 02:25:43 UTC) #7
davidben
lgtm
3 years, 8 months ago (2017-04-03 18:38:14 UTC) #8
Eugene But (OOO till 7-30)
Thanks!
3 years, 8 months ago (2017-04-03 20:54:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793733002/1
3 years, 8 months ago (2017-04-03 20:54:36 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 21:56:58 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0b9db8c1ccf56746c5046b0ce732...

Powered by Google App Engine
This is Rietveld 408576698