Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2793613004:
Add test for TimeDurationFormat() error. (Closed)
|
Created:
3 years, 8 months ago by Daniel Erat Modified:
3 years, 8 months ago Reviewers:
jungshik at Google CC:
chromium-reviews, danakj+watch_chromium.org, jshin+watch_chromium.org, vmpstr+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd test for TimeDurationFormat() error.
base::TimeDurationFormat() fails due to a
U_RESOURCE_TYPE_MISMATCH error from ICU when called with
certain locals like en_GB due to missing resource data.
Add a test (disabled for now) to verify that it works
for all supported locales.
BUG=677043, 707515
Review-Url: https://codereview.chromium.org/2793613004
Cr-Commit-Position: refs/heads/master@{#463796}
Committed: https://chromium.googlesource.com/chromium/src/+/a8550bc1391772685da6e86adc72a587bd964289
Patch Set 1 #Patch Set 2 : iterate over all supported locales #Patch Set 3 : disable test #Messages
Total messages: 22 (15 generated)
Description was changed from ========== DO NOT SUBMIT: Add test for TimeDurationFormat() error. base::TimeDurationFormat() fails due to a U_RESOURCE_TYPE_MISMATCH error from ICU when called with certain locals like en_GB. The cause is unknown. BUG=677043 ========== to ========== DO NOT SUBMIT: Add test for TimeDurationFormat() error. base::TimeDurationFormat() fails due to a U_RESOURCE_TYPE_MISMATCH error from ICU when called with certain locals like en_GB. The cause is unknown. BUG=677043,707515 ==========
Description was changed from ========== DO NOT SUBMIT: Add test for TimeDurationFormat() error. base::TimeDurationFormat() fails due to a U_RESOURCE_TYPE_MISMATCH error from ICU when called with certain locals like en_GB. The cause is unknown. BUG=677043,707515 ========== to ========== Add test for TimeDurationFormat() error. base::TimeDurationFormat() fails due to a U_RESOURCE_TYPE_MISMATCH error from ICU when called with certain locals like en_GB. The cause is unknown. BUG=677043,707515 ==========
The CQ bit was checked by derat@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
jshin@chromium.org changed reviewers: + jshin@chromium.org
https://codereview.chromium.org/2812943003/ is an ICU fix. Dan, would you land this test *disabled*? When I roll ICU to the above revision, I'll enable it.
Description was changed from ========== Add test for TimeDurationFormat() error. base::TimeDurationFormat() fails due to a U_RESOURCE_TYPE_MISMATCH error from ICU when called with certain locals like en_GB. The cause is unknown. BUG=677043,707515 ========== to ========== Add test for TimeDurationFormat() error. base::TimeDurationFormat() fails due to a U_RESOURCE_TYPE_MISMATCH error from ICU when called with certain locals like en_GB due to missing resource data. Add a test (disabled for now) to verify that it works for all supported locales. BUG=677043,707515 ==========
sure, disabled the test
The CQ bit was checked by derat@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jshin@chromium.org
Thanks, LGTM
should i go ahead and submit this? mind reviewing?
ah, you just did. thanks! :-)
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491948002258550,
"parent_rev": "58a97b349697f6764d0d0304a8374da957ef2207", "commit_rev":
"a8550bc1391772685da6e86adc72a587bd964289"}
Message was sent while issue was closed.
Description was changed from ========== Add test for TimeDurationFormat() error. base::TimeDurationFormat() fails due to a U_RESOURCE_TYPE_MISMATCH error from ICU when called with certain locals like en_GB due to missing resource data. Add a test (disabled for now) to verify that it works for all supported locales. BUG=677043,707515 ========== to ========== Add test for TimeDurationFormat() error. base::TimeDurationFormat() fails due to a U_RESOURCE_TYPE_MISMATCH error from ICU when called with certain locals like en_GB due to missing resource data. Add a test (disabled for now) to verify that it works for all supported locales. BUG=677043,707515 Review-Url: https://codereview.chromium.org/2793613004 Cr-Commit-Position: refs/heads/master@{#463796} Committed: https://chromium.googlesource.com/chromium/src/+/a8550bc1391772685da6e86adc72... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/a8550bc1391772685da6e86adc72... |
