Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2793613003:
Fix flakiness in FlashPermissionBrowserTest.BlockFileURL with PlzNavigate after r460581. (Closed)
DescriptionFix flakiness in FlashPermissionBrowserTest.BlockFileURL with PlzNavigate after r460581.
The problem was that navigation now had one less hop to the renderer, and this causes races between the old DidStop IPC and the new navigation. This doesn't happen in production, because we don't dispatch IPCs in nested message loops.
BUG=706780
Review-Url: https://codereview.chromium.org/2793613003
Cr-Commit-Position: refs/heads/master@{#463927}
Committed: https://chromium.googlesource.com/chromium/src/+/5b3bc5aa5ae314bd7f3eb2283b7b1efec8eb3499
Patch Set 1 #Patch Set 2 #Patch Set 3 : merge #Messages
Total messages: 21 (15 generated)
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jam@chromium.org changed reviewers: + sprayonbedliner4you@gmail.com
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fix flakiness in FlashPermissionBrowserTest.BlockFileURL with PlzNavigate after r460581. The problem was that navigation now had one less hop to the renderer, and this causes races between the old DidStop IPC and the new navigation. This doesn't happen in production, because we don't dispatch IPCs in nested message loops. BUG=706780 ========== to ========== Fix flakiness in FlashPermissionBrowserTest.BlockFileURL with PlzNavigate after r460581. The problem was that navigation now had one less hop to the renderer, and this causes races between the old DidStop IPC and the new navigation. This doesn't happen in production, because we don't dispatch IPCs in nested message loops. BUG=706780 ==========
jam@chromium.org changed reviewers: + tommycli@chromium.org - sprayonbedliner4you@gmail.com
lgtm thanks for the debug!
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by jam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tommycli@chromium.org Link to the patchset: https://codereview.chromium.org/2793613003/#ps40001 (title: "merge")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491968875778940,
"parent_rev": "b6dc62f53d4c3b14c0f541897f8d2970be89b84b", "commit_rev":
"5b3bc5aa5ae314bd7f3eb2283b7b1efec8eb3499"}
Message was sent while issue was closed.
Description was changed from ========== Fix flakiness in FlashPermissionBrowserTest.BlockFileURL with PlzNavigate after r460581. The problem was that navigation now had one less hop to the renderer, and this causes races between the old DidStop IPC and the new navigation. This doesn't happen in production, because we don't dispatch IPCs in nested message loops. BUG=706780 ========== to ========== Fix flakiness in FlashPermissionBrowserTest.BlockFileURL with PlzNavigate after r460581. The problem was that navigation now had one less hop to the renderer, and this causes races between the old DidStop IPC and the new navigation. This doesn't happen in production, because we don't dispatch IPCs in nested message loops. BUG=706780 Review-Url: https://codereview.chromium.org/2793613003 Cr-Commit-Position: refs/heads/master@{#463927} Committed: https://chromium.googlesource.com/chromium/src/+/5b3bc5aa5ae314bd7f3eb2283b7b... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/5b3bc5aa5ae314bd7f3eb2283b7b... |
