Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2793583002: Move all of csswg-test to wpt/css and temporarily disable all css tests. (Closed)

Created:
3 years, 8 months ago by qyearsley
Modified:
3 years, 8 months ago
Reviewers:
Nico, kojii
CC:
Bem Jones-Bey (adobe), blink-reviews, cbiesinger, chromium-reviews, drott, emilio, jfernandez, kochi, kojii, Manuel Rego, style-dev_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move all of csswg-test to wpt/css and temporarily disable all css tests. I intend to directly land this CL, so what's shown in Rietveld isn't a reflection of the true contents of the patch, which changes more than 6000 files. This commit will include: An import of just wpt/css from wpt@a810200e6e1b0b98527bd1fd791fa110646cfb91 Removal of external/csswg-test Updates to the expectation files to temporarily disable the tests NOEXPORT=true TBR=kojii TBR_REASON=preparing for follow-up CLs which enable the tests; I expect this CL to be low-risk since it disables all of the affected tests. BUG=706118 Review-Url: https://codereview.chromium.org/2793583002 . Cr-Commit-Position: refs/heads/master@{#461177} Committed: https://chromium.googlesource.com/chromium/src/+/aef3329cadaa6cc1a8d2f558cd33cce6caa95278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+596 lines, -574 lines) Patch
M third_party/WebKit/LayoutTests/LeakExpectations View 1 chunk +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/SlowTests View 1 chunk +15 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 16 chunks +569 lines, -547 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
qyearsley
3 years, 8 months ago (2017-03-31 18:12:34 UTC) #3
qyearsley
Committed patchset #1 (id:1) manually as aef3329cadaa6cc1a8d2f558cd33cce6caa95278 (presubmit successful).
3 years, 8 months ago (2017-03-31 18:31:12 UTC) #5
Nico
My sync just now brought in over 700 MB of stuff, I had synced 4h ...
3 years, 8 months ago (2017-03-31 19:39:31 UTC) #7
qyearsley
On 2017/03/31 at 19:39:31, thakis wrote: > My sync just now brought in over 700 ...
3 years, 8 months ago (2017-03-31 20:37:57 UTC) #8
qyearsley
3 years, 8 months ago (2017-03-31 21:05:56 UTC) #9
Message was sent while issue was closed.
On 2017/03/31 at 20:37:57, qyearsley wrote:
> On 2017/03/31 at 19:39:31, thakis wrote:
> > My sync just now brought in over 700 MB of stuff, I had synced 4h before
that. I'm guessing it's due to this change. Do we really want to keep all this
in git? This probably increased repo size from about 4GB to 5GB or so just now,
which doesn't sound ideal. Was file size considered before doing this? Did this
get sign-off somewhere?
> 
> I didn't get a sign-off for this change ahead of time, but was assuming that
it would be OK because:
>  - Overall, this change involved deleting many files and moving other files;
the total size of the files should be less after this change
>  - The change to move files from external/csswg-test to external/wpt/css was
planned far ahead of time, so I know we wanted to do this
> 
> Is there something that I could have done (or can do now) to decrease the size
of the history information stored in git?

Quick clarification:

This change involved:

 4754 renamed files
 1273 deleted files
  823 added files
    8 modified files

The total size of the files in third_party/WebKit/LayoutTests/ is about 1MB less
after this change. (There were no changes outside of
third_party/WebKit/LayoutTests/.)

The reason why I wanted to get this change through quickly was because (I
believe) this is blocking normal automatic import of web-platform-tests
(https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_plat...).

But I really didn't intend to increase the size of the repo or cause problems -
do you know how I could see how much this has increased the size of the repo?

Powered by Google App Engine
This is Rietveld 408576698