Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2793533003: Add UKM logging of UPI-VPA autocomplete hints. (Closed)

Created:
3 years, 8 months ago by Roger McFarlane (Chromium)
Modified:
3 years, 8 months ago
Reviewers:
Mathieu, csashi
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UKM logging of UPI-VPA autocomplete hints. BUG=702220 Review-Url: https://codereview.chromium.org/2793533003 Cr-Commit-Position: refs/heads/master@{#461171} Committed: https://chromium.googlesource.com/chromium/src/+/6eea7c4fa2707c1a33899892150af62d14ef9b54

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
M components/autofill/core/browser/autofill_metrics_unittest.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M components/autofill/core/browser/form_structure.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Roger McFarlane (Chromium)
PTAL?
3 years, 8 months ago (2017-03-31 15:46:16 UTC) #4
csashi
lgtm LGTM. Thanks for adding this metric. -sashi.
3 years, 8 months ago (2017-03-31 16:25:24 UTC) #5
csashi
lgtm LGTM. Thanks for adding this metric. -sashi.
3 years, 8 months ago (2017-03-31 16:25:26 UTC) #6
Mathieu
lgtm
3 years, 8 months ago (2017-03-31 16:40:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793533003/1
3 years, 8 months ago (2017-03-31 16:50:49 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 18:12:32 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6eea7c4fa2707c1a33899892150a...

Powered by Google App Engine
This is Rietveld 408576698