Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2793483002: Revert of [DevTools] Filtered list enhancements (Closed)

Created:
3 years, 8 months ago by pfeldman
Modified:
3 years, 8 months ago
Reviewers:
caseq, dgozman, eostroukhov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Filtered list enhancements (patchset #4 id:60001 of https://codereview.chromium.org/2781863003/ ) Reason for revert: Breaks selection, don't think was necessary at first place! Original issue's description: > [DevTools] Filtered list enhancements > > Some enhancements that are needed for the frames menu but also seem > useful for other clients of the FilteredListWidget. > 1. Selection is preserved while the filter string is being updated. > 2. Items are highlighted on hover. Provider is notified when mouse > moves over the item. > 3. It is now possible to set the selection. > > BUG=698027 > > Review-Url: https://codereview.chromium.org/2781863003 > Cr-Commit-Position: refs/heads/master@{#460799} > Committed: https://chromium.googlesource.com/chromium/src/+/76c041dbcc4de828135d0af8c39256c4861b1a01 TBR=dgozman@chromium.org,caseq@chromium.org,eostroukhov@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=698027 Review-Url: https://codereview.chromium.org/2793483002 Cr-Commit-Position: refs/heads/master@{#461239} Committed: https://chromium.googlesource.com/chromium/src/+/6bf970e99a9672baf4de427eb35dc6f3b5d0b3cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -61 lines) Patch
M third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js View 8 chunks +2 lines, -57 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/quick_open/filteredListWidget.css View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
pfeldman
Created Revert of [DevTools] Filtered list enhancements
3 years, 8 months ago (2017-03-31 01:05:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793483002/1
3 years, 8 months ago (2017-03-31 21:51:39 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 21:54:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6bf970e99a9672baf4de427eb35d...

Powered by Google App Engine
This is Rietveld 408576698