Removed NOTIFICATION_BROWSER_CLOSING notification

chrome/browser/ui/browser_commands.cc

Index: chrome/browser/ui/browser_commands.cc
diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc
index efcc39cc4d372d674a7f6f303bf3f5334abefc80..ee22aa20e2f6be836d4f53bbcb064903f11366c1 100644
--- a/chrome/browser/ui/browser_commands.cc
+++ b/chrome/browser/ui/browser_commands.cc
@@ -756,7 +756,7 @@ void ConvertPopupToTabbedBrowser(Browser* browser) {
 
 void Exit() {
   content::RecordAction(UserMetricsAction("Exit"));
-  chrome::AttemptUserExit();
+  chrome::AttemptExit();

[sky, 2017/03/31 14:23:41]

Why is this change necessary?

[Alexey Seren, 2017/04/02 12:02:35]

This is fix of shutdown histograms on windows when user exits via Ctrl+Shift+Q.
AttemptUserExit() doesn’t call browser_shutdown::SetTryingToQuit(true). So we
cannot start shutdown process correctly and chrome_shutdown_ms.txt is not
created. 
See:
https://cs.chromium.org/chromium/src/chrome/browser/lifetime/application_life...
https://cs.chromium.org/chromium/src/chrome/browser/lifetime/application_life...

chrome::AttemptExit(), оn the contrary, does what is needed.

[hashimoto, 2017/04/04 08:54:07]

This change looks wrong as the comments in application_lifetime.h says
AttemptUserExit() should be used when handling user-initiated shutdown.

[sky, 2017/04/04 16:56:49]

Agreed. The conditional you point at was added here:
https://codereview.chromium.org/25603004 . See it for the rationale as to why
the conditional.

 }
 
 void BookmarkCurrentPageIgnoringExtensionOverrides(Browser* browser) {