Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7817)

Unified Diff: chrome/browser/ui/browser_list.h

Issue 2793443003: Removed NOTIFICATION_BROWSER_CLOSING notification (Closed)
Patch Set: Added browser tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_list.h
diff --git a/chrome/browser/ui/browser_list.h b/chrome/browser/ui/browser_list.h
index 705e423d97708612cc9059cef1158f78ee55769e..a976dd7843bade9bb1a22c739e0a47be0033476e 100644
--- a/chrome/browser/ui/browser_list.h
+++ b/chrome/browser/ui/browser_list.h
@@ -57,6 +57,10 @@ class BrowserList {
return last_active_browsers_.rend();
}
+ size_t currently_closing_browsers_count() const {
+ return currently_closing_browsers_.size();
+ }
+
static BrowserList* GetInstance();
// Adds or removes |browser| from the list it is associated with. The browser
@@ -82,6 +86,12 @@ class BrowserList {
// Notifies the observers when the current active browser becomes not active.
static void NotifyBrowserNoLongerActive(Browser* browser);
+ // Notifies the observers when browser window is closing.
+ static void NotifyBrowserWindowClosing(Browser* browser);
+
+ // Notifies the observers when browser window close is cancelled.
+ static void NotifyBrowserCloseCancelled(Browser* browser);
+
// Closes all browsers for |profile| across all desktops.
// TODO(mlerman): Move the Profile Deletion flow to use the overloaded
// version of this method with a callback, then remove this method.
@@ -148,6 +158,8 @@ class BrowserList {
// A vector of the browsers in this list that have been activated, in the
// reverse order in which they were last activated.
BrowserVector last_active_browsers_;
+ // A vector of the browsers that is currently in closing state.
sky 2017/03/31 14:23:41 are currently in the
Alexey Seren 2017/04/02 12:02:35 Acknowledged.
+ BrowserVector currently_closing_browsers_;
// A list of observers which will be notified of every browser addition and
// removal across all BrowserLists.

Powered by Google App Engine
This is Rietveld 408576698