Removed NOTIFICATION_BROWSER_CLOSING notification

chrome/browser/ui/browser_commands.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_commands.h"
 
 #include "base/command_line.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
@@ skipping 738 matching lines @@
   TabStripModel* tab_strip = browser->tab_strip_model();
   WebContents* contents =
       tab_strip->DetachWebContentsAt(tab_strip->active_index());
   Browser* b = new Browser(Browser::CreateParams(browser->profile(), true));
   b->tab_strip_model()->AppendWebContents(contents, true);
   b->window()->Show();
 }
 
 void Exit() {
   content::RecordAction(UserMetricsAction("Exit"));
-  chrome::AttemptUserExit();
+  chrome::AttemptExit();

[sky, 2017/03/31 14:23:41]

Why is this change necessary?

[Alexey Seren, 2017/04/02 12:02:35]

This is fix of shutdown histograms on windows when user exits via Ctrl+Shift+Q.
AttemptUserExit() doesn’t call browser_shutdown::SetTryingToQuit(true). So we
cannot start shutdown process correctly and chrome_shutdown_ms.txt is not
created. 
See:
https://cs.chromium.org/chromium/src/chrome/browser/lifetime/application_life...
https://cs.chromium.org/chromium/src/chrome/browser/lifetime/application_life...

chrome::AttemptExit(), оn the contrary, does what is needed.

[hashimoto, 2017/04/04 08:54:07]

This change looks wrong as the comments in application_lifetime.h says
AttemptUserExit() should be used when handling user-initiated shutdown.

[sky, 2017/04/04 16:56:49]

Agreed. The conditional you point at was added here:
https://codereview.chromium.org/25603004 . See it for the rationale as to why
the conditional.

 }
 
 void BookmarkCurrentPageIgnoringExtensionOverrides(Browser* browser) {
   content::RecordAction(UserMetricsAction("Star"));
 
   BookmarkModel* model =
       BookmarkModelFactory::GetForBrowserContext(browser->profile());
   if (!model || !model->loaded())
     return;  // Ignore requests until bookmarks are loaded.
 
@@ skipping 564 matching lines @@
       true));
   app_browser->tab_strip_model()->AppendWebContents(contents, true);
 
   contents->GetMutableRendererPrefs()->can_accept_load_drops = false;
   contents->GetRenderViewHost()->SyncRendererPrefs();
   app_browser->window()->Show();
 }
 #endif  // BUILDFLAG(ENABLE_EXTENSIONS)
 
 }  // namespace chrome