Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2793403002: Adds missing kBlockingAndPassive case to TouchpadFlingScroll (Closed)

Created:
3 years, 8 months ago by brandon.furtwangler
Modified:
3 years, 8 months ago
Reviewers:
dtapuska
CC:
chromium-reviews, dtapuska+chromiumwatch_chromium.org, brandon.furtwangler_oculus.com
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds missing kBlockingAndPassive case to TouchpadFlingScroll While debugging an issue for Oculus Browser I hit the NOTREACHED case in TouchpadFlingScroll on tmz.com. This causes a crash in debug builds. Oculus Browsers gestures flings are based on vr_input_manager, so this likely applies to vr_shell as well. BUG=708236 Review-Url: https://codereview.chromium.org/2793403002 Cr-Commit-Position: refs/heads/master@{#462541} Committed: https://chromium.googlesource.com/chromium/src/+/742bb98afe29eff3d693328bc39a62f680f83a1d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M ui/events/blink/input_handler_proxy.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy_unittest.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
brandon.furtwangler
Please review my change to add a missing case for blocking and passive event listeners. ...
3 years, 8 months ago (2017-04-04 18:55:06 UTC) #6
dtapuska
On 2017/04/04 18:55:06, brandon.furtwangler wrote: > Please review my change to add a missing case ...
3 years, 8 months ago (2017-04-06 15:47:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793403002/1
3 years, 8 months ago (2017-04-06 15:48:00 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 18:00:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/742bb98afe29eff3d693328bc39a...

Powered by Google App Engine
This is Rietveld 408576698