CrOS settings/metrics: Correctly store Subscriptions

CrOS settings/metrics: Correctly store Subscriptions

Currently we do not store the Subscription for two CrosSettings
observers.

This CL:
* Adds WARN_UNUSED_RESULT to catch this in the compiler.
* Moves the chromeos::kStatsReportingPref observer code from
  metrics_reporting_state.cc to ChromeMetricsServicesManagerClient
* Stores the Subscription for chromeos::kStatsReportingPref in
  ChromeMetricsServicesManagerClient.
* Stores the Subscription for chromeos::kSystemTimezonePolicy in
  BrowserOptionsHander.

BUG=706920
Review-Url: https://codereview.chromium.org/2793393002
Cr-Commit-Position: refs/heads/master@{#462108}
Committed: https://chromium.googlesource.com/chromium/src/+/43c11caa73ca39e4d71f295b54abd7784a143d94

[stevenjb, 2017-04-04 17:58:51]

stevenjb@chromium.org changed reviewers:
+ dbeam@chromium.org, holte@chromium.org

[Steven Holte, 2017-04-04 23:02:23]

lgtm

[stevenjb, 2017-04-04 23:03:03]

The CQ bit was checked by stevenjb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 23:03:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 00:42:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 00:42:06]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2017-04-05 03:11:06]

i would argue we might not want to fix /options/, or that we should doc the
member you're adding there, but i really don't care much about /options/ at this
point

lgtm, thanks for fixing!

[stevenjb, 2017-04-05 16:26:29]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-04-05 16:27:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 16:34:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491409589853990,
"parent_rev": "e8d6c3306a359202c94dd6e5ff1a6f8718519381", "commit_rev":
"43c11caa73ca39e4d71f295b54abd7784a143d94"}

[commit-bot: I haz the power, 2017-04-05 16:35:41]

Description was changed from

==========
CrOS settings/metrics: Correctly store Subscriptions

Currently we do not store the Subscription for two CrosSettings
observers.

This CL:
* Adds WARN_UNUSED_RESULT to catch this in the compiler.
* Moves the chromeos::kStatsReportingPref observer code from
  metrics_reporting_state.cc to ChromeMetricsServicesManagerClient
* Stores the Subscription for chromeos::kStatsReportingPref in
  ChromeMetricsServicesManagerClient.
* Stores the Subscription for chromeos::kSystemTimezonePolicy in
  BrowserOptionsHander.

BUG=706920
==========

to

==========
CrOS settings/metrics: Correctly store Subscriptions

Currently we do not store the Subscription for two CrosSettings
observers.

This CL:
* Adds WARN_UNUSED_RESULT to catch this in the compiler.
* Moves the chromeos::kStatsReportingPref observer code from
  metrics_reporting_state.cc to ChromeMetricsServicesManagerClient
* Stores the Subscription for chromeos::kStatsReportingPref in
  ChromeMetricsServicesManagerClient.
* Stores the Subscription for chromeos::kSystemTimezonePolicy in
  BrowserOptionsHander.

BUG=706920

Review-Url: https://codereview.chromium.org/2793393002
Cr-Commit-Position: refs/heads/master@{#462108}
Committed:
https://chromium.googlesource.com/chromium/src/+/43c11caa73ca39e4d71f295b54ab...
==========

[commit-bot: I haz the power, 2017-04-05 16:35:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/43c11caa73ca39e4d71f295b54ab...

[stevenjb, 2017-04-05 17:18:08]

The options fix by the way was something else entirely; the symptom would
be timezone settings not receiving updates. This was caught by the added
compiler warning and needed to be fixed to remove the warning.


On Tue, Apr 4, 2017 at 8:11 PM, <dbeam@chromium.org> wrote:

> i would argue we might not want to fix /options/, or that we should doc the
> member you're adding there, but i really don't care much about /options/
> at this
> point
>
> lgtm, thanks for fixing!
>
> https://codereview.chromium.org/2793393002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.