Reset is_ticking_ when calling AnimationPlayer::RemoveFromTicking

Reset is_ticking_ when calling AnimationPlayer::RemoveFromTicking

it_ticking_ isn't cleared in this path. This means that future
animations wont be started since UpdateTickingState will think that its
already ticking and wont add itself to the AnimationHost's ticking
players list.

I believe the omission in
https://crrev.com/e7592f02242026970af0a6425928e5271a52f79d was that
when the scrolling Element is unregistered the ElementAnimations will
be removed from AnimationHost. In contrast, the AnimationPlayer lives on.
That's why ElementAnimations didn't need to clear the active/ticking
flag but AnimationHost does.

BUG=704410
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2791513002
Cr-Commit-Position: refs/heads/master@{#460966}
(cherry picked from commit a064840eb26683687c53dc6fa6b5c29a2c418b5c)

Review-Url: https://codereview.chromium.org/2793383002 .
Cr-Commit-Position: refs/branch-heads/3029@{#572}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/f6734c8dffedf23afafec4c901880122418b5aee

[bokan, 2017-04-04 17:52:36]

Description was changed from

==========
Reset is_ticking_ when calling AnimationPlayer::RemoveFromTicking

it_ticking_ isn't cleared in this path. This means that future
animations wont be started since UpdateTickingState will think that its
already ticking and wont add itself to the AnimationHost's ticking
players list.

I believe the omission in
https://crrev.com/e7592f02242026970af0a6425928e5271a52f79d was that
when the scrolling Element is unregistered the ElementAnimations will
be removed from AnimationHost. In contrast, the AnimationPlayer lives on.
That's why ElementAnimations didn't need to clear the active/ticking
flag but AnimationHost does.

BUG=704410
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2791513002
Cr-Commit-Position: refs/heads/master@{#460966}
(cherry picked from commit a064840eb26683687c53dc6fa6b5c29a2c418b5c)
==========

to

==========
Reset is_ticking_ when calling AnimationPlayer::RemoveFromTicking

it_ticking_ isn't cleared in this path. This means that future
animations wont be started since UpdateTickingState will think that its
already ticking and wont add itself to the AnimationHost's ticking
players list.

I believe the omission in
https://crrev.com/e7592f02242026970af0a6425928e5271a52f79d was that
when the scrolling Element is unregistered the ElementAnimations will
be removed from AnimationHost. In contrast, the AnimationPlayer lives on.
That's why ElementAnimations didn't need to clear the active/ticking
flag but AnimationHost does.

BUG=704410
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2791513002
Cr-Commit-Position: refs/heads/master@{#460966}
(cherry picked from commit a064840eb26683687c53dc6fa6b5c29a2c418b5c)

Review-Url: https://codereview.chromium.org/2793383002 .
Cr-Commit-Position: refs/branch-heads/3029@{#572}
Cr-Branched-From:
939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed:
https://chromium.googlesource.com/chromium/src/+/f6734c8dffedf23afafec4c90188...
==========

[bokan, 2017-04-04 17:52:39]

Committed patchset #1 (id:1) manually as
f6734c8dffedf23afafec4c901880122418b5aee (tree was closed).