[regexp] Add tests for recent changes in Annex B

[regexp] Add tests for recent changes in Annex B

See https://github.com/tc39/ecma262/pull/303.

BUG=v8:5937, v8:6201
Review-Url: https://codereview.chromium.org/2793313002
Cr-Commit-Position: refs/heads/master@{#44467}
Committed: https://chromium.googlesource.com/v8/v8/+/4498419438746bf94fc6a296ccc2eb61a57e2738

[jgruber, 2017-04-04 11:47:52]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 11:48:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-04-04 11:49:01]

jgruber@chromium.org changed reviewers:
+ littledan@chromium.org, yangguo@chromium.org

[commit-bot: I haz the power, 2017-04-04 12:09:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 12:10:00]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2017-04-04 18:20:22]

lgtm

lgtm

Awesome tests. They look valid to me. A couple follow-on suggestions:
- These could be upstream test262 tests! I understand if it's too much work to
upstream. It looks like many of these were added in
https://github.com/tc39/test262/commit/43bce311db14e2b971d3c739fcc77afc9a77499d
; I haven't looked through exhaustively to see what's missing from their tests
that you have here.
- There are comments in the RegExp parsing code which say, "for compatibility
with JSC..." or similar where it's now covered by Annex B. Since you're going
back through all this, maybe you could update those comments into spec
cross-references.
- One case which is provided in the spec, but which I don't see covered in these
tests (or in test262) is `/^\c$/.test("\\c")` (which should return true)

[jgruber, 2017-04-05 14:09:33]

On 2017/04/04 18:20:22, Dan Ehrenberg wrote:
> Awesome tests. They look valid to me. A couple follow-on suggestions:
> - These could be upstream test262 tests! I understand if it's too much work to
> upstream. It looks like many of these were added in
>
https://github.com/tc39/test262/commit/43bce311db14e2b971d3c739fcc77afc9a77499d
> ; I haven't looked through exhaustively to see what's missing from their tests
> that you have here.

Very cool, I didn't know these existed.

> - There are comments in the RegExp parsing code which say, "for compatibility
> with JSC..." or similar where it's now covered by Annex B. Since you're going
> back through all this, maybe you could update those comments into spec
> cross-references.

I'll do a pass through regexp-parser.cc.

> - One case which is provided in the spec, but which I don't see covered in
these
> tests (or in test262) is `/^\c$/.test("\\c")` (which should return true)

Ack, will add.

[jgruber, 2017-04-07 07:27:40]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 07:27:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-04-07 07:30:19]

On 2017/04/05 14:09:33, jgruber wrote:
> On 2017/04/04 18:20:22, Dan Ehrenberg wrote: 
> > - There are comments in the RegExp parsing code which say, "for
compatibility
> > with JSC..." or similar where it's now covered by Annex B. Since you're
going
> > back through all this, maybe you could update those comments into spec
> > cross-references.
> 
> I'll do a pass through regexp-parser.cc.

Updated a couple of comments.

> 
> > - One case which is provided in the spec, but which I don't see covered in
> these
> > tests (or in test262) is `/^\c$/.test("\\c")` (which should return true)
> 
> Ack, will add.

Done.

[jgruber, 2017-04-07 07:32:04]

The CQ bit was unchecked by jgruber@chromium.org

[jgruber, 2017-04-07 07:32:10]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-04-07 07:32:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
littledan@chromium.org
Link to the patchset: https://codereview.chromium.org/2793313002/#ps20001
(title: "Rebase and address comments")

[commit-bot: I haz the power, 2017-04-07 07:32:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 07:52:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491550330212650,
"parent_rev": "a8651c5671dd6e41595ffb438e7ea013082f2d38", "commit_rev":
"4498419438746bf94fc6a296ccc2eb61a57e2738"}

[commit-bot: I haz the power, 2017-04-07 07:52:17]

Description was changed from

==========
[regexp] Add tests for recent changes in Annex B

See https://github.com/tc39/ecma262/pull/303.

BUG=v8:5937,v8:6201
==========

to

==========
[regexp] Add tests for recent changes in Annex B

See https://github.com/tc39/ecma262/pull/303.

BUG=v8:5937,v8:6201

Review-Url: https://codereview.chromium.org/2793313002
Cr-Commit-Position: refs/heads/master@{#44467}
Committed:
https://chromium.googlesource.com/v8/v8/+/4498419438746bf94fc6a296ccc2eb61a57...
==========

[commit-bot: I haz the power, 2017-04-07 07:52:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/4498419438746bf94fc6a296ccc2eb61a57...