Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 2793283002: Remove LabelButton::SetFontListDeprecated(). (Closed)

Created:
3 years, 8 months ago by tapted
Modified:
3 years, 8 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove LabelButton::SetFontListDeprecated(). The last remaining call site in profile_chooser_view.cc was removed in r455113. BUG=633986 Review-Url: https://codereview.chromium.org/2793283002 Cr-Commit-Position: refs/heads/master@{#461929} Committed: https://chromium.googlesource.com/chromium/src/+/fbb840ad09271f71f680f93a4484aaef68aaf952

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M ui/views/controls/button/label_button.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/controls/button/label_button.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
tapted
incidentally... I also want to remove AdjustFontSize and the protected SetFontList (instead move things over ...
3 years, 8 months ago (2017-04-04 06:53:13 UTC) #6
Evan Stade
lgtm
3 years, 8 months ago (2017-04-04 15:06:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793283002/1
3 years, 8 months ago (2017-04-05 01:03:47 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 01:11:07 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fbb840ad09271f71f680f93a4484...

Powered by Google App Engine
This is Rietveld 408576698